Jinja2 v3 - Githubissues

conda-forge / cylc-flow-feedstock

A conda-smithy repository for cylc-flow.

BSD 3-Clause "New" or "Revised" License

3 stars 11 forks source link

Jinja2 v3 #42

Closed hjoliver closed 2 years ago

hjoliver commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Bump Jinja2 major version to 3, following https://github.com/cylc/cylc-flow/pull/4877

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hjoliver commented 2 years ago

(Note version or build number not tweaked here, as yet).

MetRonnie commented 2 years ago

I guess if this is merged without incrementing the version or build numbers, it doesn't do anything yet? Couldn't find anything in the conda-forge docs from a quick investigation

hjoliver commented 2 years ago

I'm not sure either...

MetRonnie commented 2 years ago

Converting to a draft to be on the safe side...

oliver-sanders commented 2 years ago

FYI we dropped the idea or raising PRs to the feedstock repo for dep changes. The PR templates now tell you to update setup.cfg (and conda-environment.yml if present) on the repo. Updating deps on the feedstock is now part of the release process.

Why we dropped PRs:

You end up with multiple PRs which all have to be merged with the release branch.
Testing doesn't make sense and will likely fail because CI is running against the older release.
We need to check deps match at release time anyway.

hjoliver commented 2 years ago

Roger that. Closing this...