conda-forge / cylc-flow-feedstock

A conda-smithy repository for cylc-flow.

BSD 3-Clause "New" or "Revised" License

3 stars 11 forks source link

Remove markdownsafe, match exactly dependencies from setup.py #7

Closed kinow closed 4 years ago

kinow commented 4 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

kinow commented 4 years ago

Testing the metapackage locally with this version. Just got an exception running the five workflow.

So will leave as draft until I have managed to get the whole system working, avoiding having to release multiple times this conda package.

kinow commented 4 years ago

TodayILearned

The ranges from SetupTools like ==1.* do not work in Conda.

WARNING conda.models.version:get_matcher(528): Using .* with relational operator is superfluous and deprecated and will be removed in a future version of conda. Your spec was 3.*, but conda is ignoring the .* and treating it as 3
WARNING:conda.models.version:Using .* with relational operator is superfluous and deprecated and will be removed in a future version of conda. Your spec was 2.*, but conda is ignoring the .* and treating it as 2
WARNING conda.models.version:get_matcher(528): Using .* with relational operator is superfluous and deprecated and will be removed in a future version of conda. Your spec was 2.*, but conda is ignoring the .* and treating it as 2

They are ignored and replaced by nothing, which could be dangerous. So used the >=1,<2 approach.

kinow commented 4 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.