Closed regro-cf-autotick-bot closed 3 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Build is failing in some test compilation:
[ 86%] Building CXX object unittests/unit/CMakeFiles/test_Optimizer.dir/test_Optimizer.cpp.o
In file included from /home/conda/feedstock_root/build_artifacts/dartsim_1633859965598/work/dart/math/Icosphere.hpp:104,
from /home/conda/feedstock_root/build_artifacts/dartsim_1633859965598/work/unittests/unit/test_Icosphere.cpp:34:
/home/conda/feedstock_root/build_artifacts/dartsim_1633859965598/work/dart/math/detail/Icosphere-impl.hpp: In instantiation of 'static std::pair<std::vector<typename dart::math::TriMesh<S>::Vector3>, std::vector<typename dart::math::TriMesh<S>::Triangle> > dart::math::Icosphere<S_>::computeIcosahedron(dart::math::Icosphere<S_>::S) [with S_ = double; typename dart::math::TriMesh<S>::Triangle = Eigen::Matrix<long unsigned int, 3, 1, 0, 3, 1>; typename dart::math::TriMesh<S>::Vector3 = Eigen::Matrix<double, 3, 1>; dart::math::Icosphere<S_>::S = double]':
/home/conda/feedstock_root/build_artifacts/dartsim_1633859965598/work/dart/math/detail/Icosphere-impl.hpp:134:67: required from 'void dart::math::Icosphere<S_>::build() [with S_ = double]'
/home/conda/feedstock_root/build_artifacts/dartsim_1633859965598/work/dart/math/detail/Icosphere-impl.hpp:110:3: required from 'dart::math::Icosphere<S_>::Icosphere(dart::math::Icosphere<S_>::S, std::size_t) [with S_ = double; dart::math::Icosphere<S_>::S = double; std::size_t = long unsigned int]'
/home/conda/feedstock_root/build_artifacts/dartsim_1633859965598/work/unittests/unit/test_Icosphere.cpp:48:59: required from here
/home/conda/feedstock_root/build_artifacts/dartsim_1633859965598/work/dart/math/detail/Icosphere-impl.hpp:78:24: error: converting to 'Eigen::Matrix<double, 3, 1>' from initializer list would use explicit constructor 'Eigen::Matrix<_Scalar, _Rows, _Cols, _Options, _MaxRows, _MaxCols>::Matrix(const std::initializer_list<std::initializer_list<typename Eigen::internal::traits<Eigen::Matrix<_Scalar, _Rows, _Cols, _Options, _MaxRows, _MaxCols> >::Scalar> >&) [with _Scalar = double; int _Rows = 3; int _Cols = 1; int _Options = 0; int _MaxRows = 3; int _MaxCols = 1; typename Eigen::internal::traits<Eigen::Matrix<_Scalar, _Rows, _Cols, _Options, _MaxRows, _MaxCols> >::Scalar = double]'
78 | std::vector<Vector3> vertices = {{{-x, 0, z},
| ^~~~~~~~
/home/conda/feedstock_root/build_artifacts/dartsim_1633859965598/work/dart/math/detail/Icosphere-impl.hpp:91:32: error: converting to 'Eigen::Matrix<long unsigned int, 3, 1, 0, 3, 1>' from initializer list would use explicit constructor 'Eigen::Matrix<_Scalar, _Rows, _Cols, _Options, _MaxRows, _MaxCols>::Matrix(const std::initializer_list<std::initializer_list<typename Eigen::internal::traits<Eigen::Matrix<_Scalar, _Rows, _Cols, _Options, _MaxRows, _MaxCols> >::Scalar> >&) [with _Scalar = long unsigned int; int _Rows = 3; int _Cols = 1; int _Options = 0; int _MaxRows = 3; int _MaxCols = 1; typename Eigen::internal::traits<Eigen::Matrix<_Scalar, _Rows, _Cols, _Options, _MaxRows, _MaxCols> >::Scalar = long unsigned int]'
91 | static std::vector<Triangle> triangles
| ^~~~~~~~~
make[3]: *** [unittests/unit/CMakeFiles/test_Icosphere.dir/build.make:76: unittests/unit/CMakeFiles/test_Icosphere.dir/test_Icosphere.cpp.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:3180: unittests/unit/CMakeFiles/test_Icosphere.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
[ 86%] Linking CXX executable test_Optimizer
[ 86%] Built target test_Optimizer
make[1]: *** [CMakeFiles/Makefile2:2155: unittests/CMakeFiles/tests.dir/rule] Error 2
make: *** [Makefile:426: tests] Error 2
Traceback (most recent call last):
Sound like a Eigen 3.4 compilation problem.
New error:
/home/conda/feedstock_root/build_artifacts/dartsim_1633884461620/work/unittests/unit/test_Signal.cpp: In member function 'virtual void Signal_NonStaticMemberFunction_Test::TestBody()':
/home/conda/feedstock_root/build_artifacts/dartsim_1633884461620/work/unittests/unit/test_Signal.cpp:142:9: error: reference to 'placeholders' is ambiguous
142 | using placeholders::_1;
| ^~~~~~~~~~~~
from /home/conda/feedstock_root/build_artifacts/dartsim_1633884461620/work/build/dart/common/common.hpp:26,
from /home/conda/feedstock_root/build_artifacts/dartsim_1633884461620/work/dart/dart.hpp:35,
from /home/conda/feedstock_root/build_artifacts/dartsim_1633884461620/work/unittests/unit/test_Signal.cpp:36:
/home/conda/feedstock_root/build_artifacts/dartsim_1633884461620/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include/boost/mpl/aux_/preprocessed/gcc/placeholders.hpp:42:16: note: 'mpl_::_2'
42 | typedef arg<2> _2;
| ^~
All the build are not working, the only problems are the following Windows tests that are failing:
The following tests FAILED:
2 - test_CollisionGroups (Failed)
3 - test_ContactConstraint (Failed)
21 - test_FileInfoWorld (Failed)
23 - test_MjcfParser (Failed)
24 - test_SdfParser (Failed)
25 - test_SkelParser (Failed)
It seems that this test are passing in Dart vcpkg-based upstream Windows CI: https://github.com/dartsim/dart/runs/3654028003 .
I was able to reproduce this failure on latest dart (https://github.com/dartsim/dart/commit/7e3db63a07f7fcabd577efbd0487c6cd99e31c34):
The following tests FAILED:
2 - test_CollisionGroups (Failed)
3 - test_ContactConstraint (Failed)
21 - test_FileInfoWorld (Failed)
23 - test_MjcfParser (Failed)
24 - test_SdfParser (Failed)
25 - test_SkelParser (Failed)
conda list:
The test are fixed once one installs eigen 3.3.9, that was the version with which fcl 0.6.1 was compiled. So it seems that indeed there are Eigen ABI problems related to different Eigen minor versions, as it was suggested by ceres developers in https://github.com/conda-forge/ceres-solver-feedstock/issues/19 . For some reason this problem emerge just on Windows. The long term solution is to add proper run_export('eigen')
to all libraries (like fcl and dart) that use Eigen in their public interfaces, but in the short term the easier solution is just to rebuild fcl with Eigen 3.4.0 .
but in the short term the easier solution is just to rebuild fcl with Eigen 3.4.0 .
Related to this, at this point better to wait for https://github.com/conda-forge/fcl-feedstock/pull/11 to get merged, and then we can restart the CI of this PR and hopefully merge it.
Indeed, after merging https://github.com/conda-forge/fcl-feedstock/pull/11 that uses Eigen 3.4.0 the tests on Windows are working fine.
It is very likely that the current package version for this feedstock is out of date. Notes for merging this PR:
license_file
is packagedNote that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
NEW: If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</code
please add bot automerge
in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever
) and pip (pip install re-ver
) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1033382486, please use this URL for debuggingDependency Analysis
We couldn't run dependency analysis due to an internal error in the bot. :( Help is very welcome!