Add Windows compilation

conda-forge / dartsim-feedstock

A conda-smithy repository for dartsim.

BSD 3-Clause "New" or "Revised" License

1 stars 6 forks source link

Add Windows compilation #6

Closed traversaro closed 3 years ago

traversaro commented 3 years ago

Add Windows support by backporting the https://github.com/dartsim/dart/pull/1541 to 6.9 releases.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 3 years ago

@conda-forge-admin, please rerender

traversaro commented 3 years ago

Backport of https://github.com/dartsim/dart/pull/1541 and https://github.com/dartsim/dart/pull/1542 worked fine, PR is ready for review to be merged. fyi @wolfv @Tobias-Fischer

Tobias-Fischer commented 3 years ago

LGTM, thanks!

wolfv commented 3 years ago

the only comment I have is that this builds a static lib on Windows, but I think that's fine (especially if it would be difficult to turn on dll compilation).

wolfv commented 3 years ago

awesome stuff, btw!

traversaro commented 3 years ago

the only comment I have is that this builds a static lib on Windows, but I think that's fine (especially if it would be difficult to turn on dll compilation).

Yes, upstream issue: https://github.com/dartsim/dart/issues/1501 .

wolfv commented 3 years ago

Alright. very cool, the robotics ecosystem on conda-forge is really growing a lot.