Closed jslee02 closed 4 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
openscenegraph
is not available on linux_aarch64 and linux_ppc64le, but I don't know how to disable it for them.
The valid preprocessor selectors are documented in https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#preprocessing-selectors, I guess linux-64
should be linux64
.
Removed
run:
as it seems for python packages, according to https://conda-forge.org/docs/maintainer/adding_pkgs/#run
That is indeed true, but as dartsim
is mainly a C++ library that uses Eigen in its public headers, removing eigen from the run dependencies will mean that find_package(DART)
would fail out of the box |(either directly or during compilation, not sure), unless the users manually install eigen.
Removed
run:
as it seems for python packages, according to https://conda-forge.org/docs/maintainer/adding_pkgs/#runThat is indeed true, but as
dartsim
is mainly a C++ library that uses Eigen in its public headers, removing eigen from the run dependencies will mean thatfind_package(DART)
would fail out of the box |(either directly or during compilation, not sure), unless the users manually install eigen.
Dose this mean all the transitive deps of a C++ library should be listed in run:
? What about other deps like tinyxml2 that is also exposed in the public headers of DART
I've added back the runtime dependencies for now until I figure out how they work clearly, as it's already working, so it's better than breaking it.
Removed
run:
as it seems for python packages, according to https://conda-forge.org/docs/maintainer/adding_pkgs/#runThat is indeed true, but as
dartsim
is mainly a C++ library that uses Eigen in its public headers, removing eigen from the run dependencies will mean thatfind_package(DART)
would fail out of the box |(either directly or during compilation, not sure), unless the users manually install eigen.Dose this mean all the transitive deps of a C++ library should be listed in
run:
? What about other deps like tinyxml2 that is also exposed in the public headers of DART
That is indeed a point that is not super clear, and for which I do not think there is a lot of consensus among conda-forge mantainers. However, if the library that you are exposing in the public headers is a compiled one (for example tinyxml2
, as opposed to a header-only like eigen), the run dependency is already inserted automatically as tinyxml2
is required to run any program that uses dart's shared library, and so find_package(DART)
will work fine as a byproduct.
Alright, it sounds like there's a lot to learn, and it will take time to establish good practices.
By the way, I needed to add boost as a transitive dependency when adding pagmo
in https://github.com/conda-forge/dartsim-feedstock/pull/78, which I guess is one of the cases you were worried about.
Yay, I confirmed that libdart-gui-osg.so
is installed:
By the way, I needed to add boost as a transitive dependency when adding
pagmo
in #78, which I guess is one of the cases you were worried about.
Yes, that is the case. I know that some packages also have a <pkg>-devel
or <pkg>-dev
output to handle that, but it is not so widespread.
Hi! This is the friendly conda-forge automerge bot!
I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)Changes:
doxygen
as a build depRemovedrun:
as it seems for python packages, according to https://conda-forge.org/docs/maintainer/adding_pkgs/#runflann
dependency