conda-forge / dartsim-feedstock

A conda-smithy repository for dartsim.
BSD 3-Clause "New" or "Revised" License
1 stars 6 forks source link

Depend on bullet-cpp and check that bullet collision detector is built and fix linking of fcl and assimp on Windows #8

Closed traversaro closed 3 years ago

traversaro commented 3 years ago

Now the pure C++ bullet library is contained in the bullet-cpp package (see https://github.com/conda-forge/bullet-feedstock/pull/28). Furthermore, as in some downstream projects I will require the buller collision detector (see https://github.com/ignitionrobotics/ign-physics/pull/225 and https://github.com/ignitionrobotics/ign-physics/pull/239) better to apply Beyonce' Rule and add a test for it.

Also, fix link with fcl and assimp by backporting https://github.com/dartsim/dart/pull/1510 .

Checklist

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

wolfv commented 3 years ago

Phew, looks like the bullet-cpp build does the job? :)

traversaro commented 3 years ago

Phew, looks like the bullet-cpp build does the job? :)

It seems so!

traversaro commented 3 years ago

Travis build blocked by https://github.com/conda-forge/bullet-feedstock/pull/30 .

traversaro commented 3 years ago

Travis build blocked by conda-forge/bullet-feedstock#30 .

Fixing ppc64le on bullet probably may take some more time, so let's merge and we will fix the ppc64le builds later.

wolfv commented 3 years ago

sounds good!