conda-forge / dash-feedstock

A conda-smithy repository for dash.
BSD 3-Clause "New" or "Revised" License
3 stars 8 forks source link

Removed the upper pins for Flask and Werkzeug. #132

Closed moorepants closed 1 year ago

moorepants commented 1 year ago

Upper pins make it very difficult or even impossible to manage conda environments and Dash has unwisely added them upstream. In this case, we should ensure the conda packages work smoothly within the conda ecosystem and not adopt these upper pins in the feedstock.

As mentioned here https://github.com/conda-forge/dash-feedstock/pull/129#issuecomment-1576382853

"I would rather we see how it goes without the upper pins. If we starting getting bug reports on it, then we can assess." -- moorepants

We have not received any bug reports, so I am removing the upper pins that were added without review in:

263e67dace9c150c95bf8aeca124f755e9b0ac11

Checklist

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

moorepants commented 1 year ago

@conda-forge-admin, please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/dash-feedstock/actions/runs/5419744521.

moorepants commented 1 year ago

I'm merging this without review due because it is reverting changes added without review.