search

conda-forge / dash-feedstock

A conda-smithy repository for dash.
BSD 3-Clause "New" or "Revised" License
3 stars 8 forks source link

Update to match requires-install #140

Closed rxm7706 closed 12 months ago

rxm7706 commented 12 months ago

https://github.com/plotly/dash/blob/v2.14.0/requires-install.txt

Checklist

I was running into issues using a pip environment for development and conda for packaging - and noticed that 1) there were packages in https://github.com/plotly/dash/blob/v2.14.0/requires-install.txt that were missing from the conda-recipe i.e. python <3.7 requires importlib-metadata & contextvars 2) there were to additional pins that were only in source / requirements i.e Flask>=1.0.4,<2.3.0 & Werkzeug<2.3.0 3) Since dash_html_components, dash_core_components and dash_table are in requires install - I suppose they should not be in run-constrained - but part of the run section.

conda-forge-webservices[bot] commented 12 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-webservices[bot] commented 12 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

rxm7706 commented 12 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 12 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/dash-feedstock/actions/runs/6517608901.

moorepants commented 12 months ago

I have decided not to add the dash upper bounds pins on purpose. It will cause issues when trying to install it with other packages. I don't intend to accept this PR, sorry.

moorepants commented 12 months ago

there were packages in https://github.com/plotly/dash/blob/v2.14.0/requires-install.txt that were missing from the conda-recipe i.e. python <3.7 requires importlib-metadata & contextvars

As far as I understand, conda-forge is not building for Python < 3.7 (Python 3.7 is even already end of life).

there were to additional pins that were only in source / requirements i.e Flask>=1.0.4,<2.3.0 & Werkzeug<2.3.0

These are purposely left off in the recipe to minimize difficulties in solving environments. You can always add them yourself when building a conda env if desired.

Since dash_html_components, dash_core_components and dash_table are in requires install - I suppose they should not be in run-constrained - but part of the run section.

All of these are vendored in dash now, they are only present in this recipe in case you have them installed from the separately from conda, which is unlikely to occur.

rxm7706 commented 12 months ago

I have decided not to add the dash upper bounds pins on purpose. It will cause issues when trying to install it with other packages. I don't intend to accept this PR, sorry.

@moorepants thanks - the real issue I ran into was while building package recipes depending on dash - they fail pip check ; and generally the direction has been to raise PRs to fix issues at the source. Didn't realize the choice here was intentional. Thanks for taking the time to explain.

moorepants commented 12 months ago

I see. If you want to raise an issue about pip check, maybe there are some things to address, but this recipe has basically deviated from the upstream for various reasons since its creation.