Changed the version number (1.4.1) of 'set version' and removed 'v' f…

[rowbotham-evan]

…rom source url

Checklist

• [ ] Used a personal fork of the feedstock to propose changes
• [ ] Bumped the build number (if the version is unchanged)
• [ ] Reset the build number to 0 (if the version changed)
• [ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• [ ] Ensured the license file is being packaged.

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[Sparks29032]

The bot marked this version update as errored.

Evan's edit should have fixed this (removing the 'v') since I can access the download manually with the new link. Not sure how to get us unerrored though.

[sbillinge]

can you ask for it to rerender in the comment section?

On Mon, Oct 23, 2023 at 4:03 PM Sparky @.***> wrote:

The bot marked this version update as errored https://conda-forge.org/status/#version_updates. [image: image] https://user-images.githubusercontent.com/59151395/277463533-47b4560e-9bf2-4194-b2fc-f46f9d028c07.png

Evan's edit should have fixed this (removing the 'v') since I can access the download manually with the new link. Not sure how to get us unerrored though.

— Reply to this email directly, view it on GitHub https://github.com/conda-forge/diffpy.pdffit2-feedstock/pull/14#issuecomment-1775934210, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUKHMC4WU5PDECA7GNLYA3ESPAVCNFSM6AAAAAA6LEHKF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZVHEZTIMRRGA . You are receiving this because your review was requested.Message ID: @.***>

-- Simon Billinge Professor, Department of Applied Physics and Applied Mathematics Columbia University

[Sparks29032]

@conda-forge-admin, please rerun bot

[Sparks29032]

Maybe have to merge this PR first? To prevent erroring again.

[sbillinge]

Maybe have to merge this PR first? To prevent erroring again.

I don't think we want to merge something that is not working. we could close it and start over. Shall we do that?

[sbillinge]

oh wait I see, you need the 'v' change to the recipe to merged to update the recipe. Is the concern though that when we merge something here it does a build and deploys to products to conda-forge so it will break everything on conda-forge?

[Sparks29032]

Hmm, I see. Maybe we can try doing this change in the bot's fork? (But that fork is like 30+ commits behind.) Or maybe wait until the bot runs again and proceed after that? Or maybe as a dirty fix, we change the file name on diffpy.pdffit2 to include the v. (First asset on this release).

Maybe also good to tie the source to pypi instead of gh?

[sbillinge]

sorry, not sure!

On Mon, Oct 23, 2023 at 5:27 PM Sparky @.***> wrote:

Hmm, I see. Maybe we can try doing this change in the bot's fork? (But that fork is like 30+ commits behind.)

— Reply to this email directly, view it on GitHub https://github.com/conda-forge/diffpy.pdffit2-feedstock/pull/14#issuecomment-1776049159, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUOD3CU7R2PZCKIGUV3YA3OLPAVCNFSM6AAAAAA6LEHKF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZWGA2DSMJVHE . You are receiving this because your review was requested.Message ID: @.***>

-- Simon Billinge Professor, Department of Applied Physics and Applied Mathematics Columbia University

[Sparks29032]

Something else other than incorrect hashing may be causing these tests to fail: see PR #15

[Sparks29032]

Nvm, I was being a bit silly: changing the hash properly seems to have all the tests pass on PR #15

[bobleesj]

Closing this PR since we no longer version 1.4.1, etc.