1.4.4rc0 - Githubissues

conda-forge / diffpy.pdffit2-feedstock

A conda-smithy repository for diffpy.pdffit2.

BSD 3-Clause "New" or "Revised" License

0 stars 7 forks source link

1.4.4rc0 #19

Closed Sparks29032 closed 2 months ago

Sparks29032 commented 3 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see https://github.com/conda-forge/conda-forge.github.io/issues/2102.

sbillinge commented 2 months ago

@Sparks29032 please let me know what you want me to do with this. It is currently failing, clearly.

Sparks29032 commented 2 months ago

I think it's unable to find tests or use the pytest.ini file (failing due to finding 0 tests). I thonk once we rename our tests to follow pytest convention these will pass. We can close this though.

sbillinge commented 2 months ago

closing per @Sparks29032