Package .NET Core 2.1 - Githubissues

conda-forge / dotnet-feedstock

A conda-smithy repository for dotnet.

BSD 3-Clause "New" or "Revised" License

4 stars 5 forks source link

Package .NET Core 2.1 #18

Closed acesnik closed 3 years ago

acesnik commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

dhirschfeld commented 3 years ago

Any particular reason we want to support this? I'd rather tell people to update to a modern .NET than add maintenance burden for a version that will be out of support in a few months.

That said, if you want to take this on because you have a desperate need for it then it's fine I guess.

acesnik commented 3 years ago

My motivation here is that an important closed-source tool in my field currently requires .NET Core 2.1 (http://coxdocs.org/doku.php?id=maxquant:common:download_and_installation). I'd suggest we just package this once, so that it's available to them but not do continued maintenance.

acesnik commented 3 years ago

I'm not attached to the idea or desperate for the version, though, so either way is fine by me.

dhirschfeld commented 3 years ago

Since you've already done the work we may as well merge it!

I might get you to retarget the PR (or open a new one) against the v2 branch though: https://github.com/conda-forge/dotnet-feedstock/tree/v2

acesnik commented 3 years ago

Sounds good! I retargeted v2. It should be ready to go.