Test that dotnet-runtime can return runtimes available (v3)

conda-forge / dotnet-feedstock

A conda-smithy repository for dotnet.

BSD 3-Clause "New" or "Revised" License

4 stars 5 forks source link

Closed acesnik closed 3 years ago

acesnik commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

acesnik commented 3 years ago

List of changes:

Changed build_platform to target_platform because it seems more precise. Mentioned here (conda-forge/staged-recipes#14623 (comment)).
Specify DOTNET_ROOT in the small executable for macOS/Linux. Right now, it's doesn't appear to be set. Not sure how to fix that.
Test dotnet --list-runtimes with dotnet-runtime, which is closer to its function