update v5 - Githubissues

conda-forge / dotnet-feedstock

A conda-smithy repository for dotnet.

BSD 3-Clause "New" or "Revised" License

4 stars 5 forks source link

update v5 #34

Closed acesnik closed 3 years ago

acesnik commented 3 years ago

Also, alphabetized the targets in meta.yaml

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

acesnik commented 3 years ago

No idea how to fix these ICU build issues. I posted an issue to that feedstock.

dhirschfeld commented 3 years ago

No idea how to fix these ICU build issues.

No idea either, sorry. It seems that ICU installed by CF is being picked up on all platforms other than aarch64. I wonder if the message:

Couldn't find a valid ICU package installed on the system

...means it couldn't find the CF version at all, or that there was some (swallowed) exception when trying to load it.

dhirschfeld commented 3 years ago

There's not a huge demand for aarch64 so maybe we just disable that platform and if someone cares they can try to open a PR to re-enable it?

acesnik commented 3 years ago

Shoot, it finally happened: I pushed to the wrong remote just now. I already deleted the rogue branches on the feedstock, and I'll update the build number now.

Plus a $ git remote rename origin originDoNotPushHere is in order. 😅