Closed acesnik closed 2 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Added testing of DOTNET_ROOT and DOTNET_TOOLS. Those are ones I've used. Should we test all the ones set in build.sh
?
Sorry for the radio silence - I'm spread a bit too thin to keep up with things 😬
Should we test all the ones set in
build.sh
?
I think we should probably aim towards that goal, but we don't need to get there in a single PR. Any individual improvement in that direction can (and should IMHO) be merged - perfect is the enemy of shipped as they say!
Not sure what's going on with OSX here (and I don't have access to OSX to test). I'll have a poke about in the next few weeks to try and figure it out if you don't beat me to it...
☝️ thought I'd give one thing a go. Unfortunately, my bash skills are rubbishstill a work in progress...
Looks like the same error still :/
+ test -z /Users/runner/miniforge3/conda-bld/dotnet_1638267189740/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/dotnet
Looks good for now!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)