conda-forge / eigen-feedstock

A conda-smithy repository for eigen.
BSD 3-Clause "New" or "Revised" License
2 stars 15 forks source link

eigen v3.4.0 #33

Closed regro-cf-autotick-bot closed 3 years ago

regro-cf-autotick-bot commented 3 years ago

It is very likely that the current package version for this feedstock is out of date. Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version. Checklist before merging this PR:
    • [ ] Dependencies have been updated if changed: see upstream
    • [ ] Tests have passed
    • [ ] Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1144844076, please use this URL for debugging

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows no discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 3 years ago

@conda-forge-admin, please restart ci

traversaro commented 3 years ago

Two failures.

On Windows, basicstuff_8 is not compiled but it is expected to be a test:

2021-08-26T08:33:14.5323839Z Unable to find executable: basicstuff_8
2021-08-26T08:33:14.5324414Z Could not find executable basicstuff_8
2021-08-26T08:33:14.5325499Z Looked in the following places:
2021-08-26T08:33:14.5326101Z basicstuff_8
2021-08-26T08:33:14.5326669Z basicstuff_8.exe
2021-08-26T08:33:14.5327385Z Release/basicstuff_8
2021-08-26T08:33:14.5328221Z Release/basicstuff_8.exe
2021-08-26T08:33:14.5328802Z Debug/basicstuff_8
2021-08-26T08:33:14.5329291Z Debug/basicstuff_8.exe
2021-08-26T08:33:14.5329847Z MinSizeRel/basicstuff_8
2021-08-26T08:33:14.5330399Z MinSizeRel/basicstuff_8.exe
2021-08-26T08:33:14.5330909Z RelWithDebInfo/basicstuff_8
2021-08-26T08:33:14.5331470Z RelWithDebInfo/basicstuff_8.exe
2021-08-26T08:33:14.5331971Z Deployment/basicstuff_8
2021-08-26T08:33:14.5332490Z Deployment/basicstuff_8.exe
2021-08-26T08:33:14.5332974Z Development/basicstuff_8
2021-08-26T08:33:14.5333485Z Development/basicstuff_8.exe
2021-08-26T08:33:14.5334065Z 8/8 Test #58: basicstuff_8 .....................***Not Run   0.00 sec

It may be some kind of bug in ei_add_test function : https://gitlab.com/libeigen/eigen/-/blob/3.4.0/cmake/EigenTesting.cmake#L185 . Perhaps it could make sense to just set EIGEN_SPLIT_LARGE_TESTS to OFF on Windows.

On linux_ppc64, instead a test is failing with:

8/8 Test #58: basicstuff_8 .....................Subprocess aborted***Exception:   0.39 sec

88% tests passed, 1 tests failed out of 8

Label Time Summary:
Official    =  21.15 sec*proc (8 tests)

Probably it could make sense to enable print to understand the error.

traversaro commented 3 years ago

It may be some kind of bug in ei_add_test function : https://gitlab.com/libeigen/eigen/-/blob/3.4.0/cmake/EigenTesting.cmake#L185 . Perhaps it could make sense to just set EIGEN_SPLIT_LARGE_TESTS to OFF on Windows.

The reason was much simpler, and it was due to an hardcoded 7 in bld.bat, I fixed it in https://github.com/conda-forge/eigen-feedstock/pull/34/commits/7d56fcafafbf4e6737320163278727076ff3fb10 .

traversaro commented 3 years ago

Superseded by https://github.com/conda-forge/eigen-feedstock/pull/36 .