search

conda-forge / eigen-feedstock

A conda-smithy repository for eigen.
BSD 3-Clause "New" or "Revised" License
2 stars 15 forks source link

Update to official version 3.4.1 from branch 3.4 #45

Open tegarriott opened 1 month ago

tegarriott commented 1 month ago

Solution to issue cannot be found in the documentation.

Issue

On the eigen project, on branch 3.4, a commit for an update to version 3.4.1 was pushed, but this release was not tagged: https://gitlab.com/libeigen/eigen/-/commit/bae907b8f6078b1df290729eef946360315bd312

This release fixes a crash from this issue: https://gitlab.com/libeigen/eigen/-/merge_requests/1318

The recipe should be updated so this sha is pointed to so that the bug is fixed.

Installed packages

N/A

Environment info

N/A
traversaro commented 1 month ago

We can't publish a 3.4.1 release until Eigen upstream itself releases it, as it is confusing for users if we make up releases and as otherwise what we will do when 3.4.1 is actually tagged?

If the fix for the crash can be backported to 3.4.0, probably it can make sense to backport the fix to 3.4.0 .

traversaro commented 1 month ago

If the fix for the crash can be backported to 3.4.0, probably it can make sense to backport the fix to 3.4.0 .

The fix seems minimal, did you tried to apply it to 3.4.0?

tegarriott commented 1 month ago

If the fix for the crash can be backported to 3.4.0, probably it can make sense to backport the fix to 3.4.0 .

The fix seems minimal, did you tried to apply it to 3.4.0?

Will look into making a patch.