Revert conda-smithy VS9 workaround

conda-forge / eigen-feedstock

A conda-smithy repository for eigen.

BSD 3-Clause "New" or "Revised" License

2 stars 15 forks source link

Revert conda-smithy VS9 workaround #5

Closed patricksnape closed 8 years ago

patricksnape commented 8 years ago

This reverts commit 1b36a6e65f5e85f6546284a5b378ac88066904de, reversing changes made to a14613ccbe60f7c762c4257e2ba601bea6f75bf6.

This should hopefully represent the new build system and the latest conda-build should sort this out.

conda-forge-linter commented 8 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The recipe must have a build/number section.

conda-forge-linter commented 8 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 8 years ago

So, sorry in advance as this isn't obvious, but any branch on a feedstock will deploy anything it builds. This is used for multi-version feedstocks (as we will likely do with OpenCV). However, it isn't used that often and more often people don't like having tons of forked copies of feedstocks or forget/are unaware that this will happen. We are looking positively at proposition which would force branches that deploy to explicitly declare that they do this ( https://github.com/conda-forge/conda-forge.github.io/issues/87 ), but it has not yet been implemented.

jakirkham commented 8 years ago

Have absorbed these changes into this PR ( https://github.com/conda-forge/eigen-feedstock/pull/6 ) to get us off the main repo. Thanks @patricksnape.

patricksnape commented 8 years ago

@jakirkham OK fair enough.

jakirkham commented 8 years ago

Sorry about the confusion. We really should have this stuff documented.

Though if it does pass feel free to merge it. If there is anything I missed, please let me know. Will be out, but should be back Tuesday at the latest.