Fix patches for emacs=28.1 build.

[erykoff]

Checklist

• [ ] Used a personal fork of the feedstock to propose changes
• [ ] Bumped the build number (if the version is unchanged)
• [ ] Reset the build number to 0 (if the version changed)
• [ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• [ ] Ensured the license file is being packaged.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[erykoff]

Well, the good news is that it got past the patches. The bad news is that something more difficult is going wrong. I should have some time in the next few days to investigate, but this is more than a quick fix unfortunately, unless somebody else see what's going on with the bad symbol...

[asmeurer]

No idea. That's not caused by your patches is it?

I tried building it locally, but conda build just gives me the error TypeError: Object of type date is not JSON serializable, and I have no idea how to fix it.

[erykoff]

I tried building locally (via debug, maybe I messed something up), but that gave me an AppKit could not be run error. And only one of the patches is applied to native osx-64 builds, and that has to do with code signing, so shouldn't be relevant here. But I will keep digging.

[erykoff]

A-ha! man page for openat says The openat() function was introduced in OS X 10.10, and we build osx_64 by default to a 10.9 target, and osx_arm64 to an 11.0 target so that builds. We can work around this, give me a moment.

[erykoff]

FYI, I'm following https://conda-forge.org/docs/maintainer/knowledge_base.html#requiring-newer-macos-sdks . First trying the newer SDK, if that doesn't work, I'll bump the deployment target and update the run requirements.

[asmeurer]

By the way, we might want to try using the new --with-native-compilation configure flag (see https://www.masteringemacs.org/article/speed-up-emacs-libjansson-native-elisp-compilation). But maybe it would be best to do that in a later PR as it might not be straightforward.

[erykoff]

I don't see libgccjit or anything like that on conda forge, so that sounds like a much heavier lift.

[erykoff]

If this doesn't work, I think we need all-of-the-above (sdk, deployment, config flag).

[erykoff]

Progress, but the post-link script is now not working. Is it possible to download artifacts from the azure builds to see what the layout is?

[erykoff]

Look at that, it builds! I think I need to ping @conda-forge/core to confirm that we're allowed to bump the macos version number.

[asmeurer]

All green. Is this ready to go?

[erykoff]

From my perspective, it is ready. Though I won't be able to test the osx-arm64 version until it is merged and distributed.

[asmeurer]

OK, let's try it.