search

conda-forge / epics-base-feedstock

A conda-smithy repository for epics-base.
BSD 3-Clause "New" or "Revised" License
0 stars 6 forks source link

ARM OSX Migrator #18

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

This feedstock is being rebuilt as part of the ARM OSX migration.

Feel free to merge the PR if CI is all green, but please don't close it without reaching out the the ARM OSX team first at @conda-forge/help-osx-arm64.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2388436278, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

beenje commented 2 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/epics-base-feedstock/actions/runs/2398758732.

beenje commented 2 years ago

@mrakitin or @tacaswell this PR is now ready for review. I took the opportunity to clean the outputs (no need to repeat the build requirements) and fix #19.

I don't have an Apple M1 to test but the output seems correct.

beenje commented 2 years ago

From my previous experience dealing with outputs, I learned that the package and the output names should be different as well as the relevant dependencies shoul be moved to the outputs level, otherwise the same build will happen twice in 2 different environments.

I have several recipes where one of the output is the same as the package name and never had issues. You can see in the logs that the build happens only once. I did compare the outputs before and after this change for Linux. Same index.json for epics-base. A small difference for epics-base-static-libs (libgcc-ng and libstdcxx-ng aren't in the dependencies anymore) which has no impact as it depends on epics-base.