conda-forge / epics-base-feedstock

A conda-smithy repository for epics-base.
BSD 3-Clause "New" or "Revised" License
0 stars 6 forks source link

Update to 7.0.3.1 and refactor #6

Closed beenje closed 4 years ago

beenje commented 4 years ago

Checklist

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

For recipe:

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

beenje commented 4 years ago

@conda-forge-admin, please rerender

beenje commented 4 years ago

I actually think it would make more sense to keep epics-base with almost everything and move the static libraries to a different subpackage. The static libs are quite big. Does anyone really use them? Having a subpackage would still allow to install them if you want and that would make epics-base smaller.

beenje commented 4 years ago

@hhslepicka you are welcome to comment as well.

hhslepicka commented 4 years ago

@beenje module the PyEPICS variables I think that it is a great change to be applied. About the static libs, I think that it is fine the way you proposed it as a separated package. Thanks a lot for working on that.

simongregorebner commented 4 years ago

Hey @hhslepicka @beenje thanks a lot for your work! As I more or less have no time at all to have a look at this, would you be interested to take over the maintenance of this stock from my side?

beenje commented 4 years ago

Hey @hhslepicka @beenje thanks a lot for your work! As I more or less have no time at all to have a look at this, would you be interested to take over the maintenance of this stock from my side?

On my side, I'm interested in maintaining this recipe. I'll add myself to the maintainer list.