conda-forge / esmpy-feedstock

A conda-smithy repository for esmpy.
BSD 3-Clause "New" or "Revised" License
6 stars 15 forks source link

enable `noarch` or `arm64` #53

Closed aaronspring closed 2 years ago

aaronspring commented 2 years ago

for apple silicon arm64

Checklist

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

aaronspring commented 2 years ago

probably noarch doesnt work, but I'd like to add arm64 https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#preprocessing-selectors

aaronspring commented 2 years ago

try https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/2452 following https://conda-forge.org/docs/maintainer/knowledge_base.html#apple-silicon-builds

xylar commented 2 years ago

@aaronspring, you will need to rerender for these changes to be noticed and the build to occur properly.

However, I don't think you can use noarch: python in combination with various MPI versions. I could be wrong but I'm not aware of any repo that does this.

xylar commented 2 years ago

@conda-forge-admin, please rerender

xylar commented 2 years ago

Yeah, see this above: https://github.com/conda-forge/esmpy-feedstock/pull/53#issuecomment-1024394526

noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

xylar commented 2 years ago

A reason this feedstock hasn't been built for arm64 is that ESMF has not been built yet for those architectures: https://github.com/conda-forge/esmf-feedstock/tree/master/.ci_support. I'm not sure why not. It seems it is just getting skipped by the migration bot: https://conda-forge.org/status/#other_migrations.

I can look into it. But making this package noarch isn't going to help you.

aaronspring commented 2 years ago

can look into it. But making this package noarch isn't going to help you.

Thanks for the explanation. So I better close this PR?

xylar commented 2 years ago

Yes, I'm afraid so. But it was an important thing for you to point out that we're missing. I will try to work on it over the weekend, but it might be quite a bit over my head if I run into trouble with ESMF.