Closed xylar closed 1 year ago
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
python >=3.6
in both host
and run
but you should check upstream for the package's Python compatibility.@conda-forge-admin, please rerender
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
python >=3.6
in both host
and run
but you should check upstream for the package's Python compatibility.Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
@zklaus, @ocefpaf and @rokuingh, I think this is working (though we won't know if it works for non-linux-64 architectures until we build a package).
I can confirm that mpi4py
is optional:
https://github.com/esmf-org/esmf/blob/v8.4.1/src/addon/esmpy/doc/install.rst
It also seems that one can install with esmf * nompi_*
and test just fine with esmf * mpi_mpich_*
so I think MPI isn't going to give us trouble.
As part of installation, we run the serial tests, and in the test
phase we run MPI tests so I'm feeling like testing is about as thorough as it can reasonably be on on architecture.
Please let me know what you think.
@billsacks, would you or someone from the ESMF team be able to provide feedback on whether a noarch: python
build for ESMPy is safe? We have the impression it is but want to be sure.
Also, it doesn't seem like @rokuingh is available at the moment. Is there someone else from the team that would be willing to join this (and the ESMF feedstock) as a maintainer?
As you have found, @rokuingh 's availability is very limited right now. And, unfortunately, the ESMF team as a whole is currently at a reduced size; we are hoping to build it back up somewhat in the near future. I am trying to fill in for @rokuingh on critical ESMPy issues as part of my half-time work on ESMF, but I'm still very much in a learning phase myself. You can add me as a maintainer in order to keep me in the loop and act as a liaison between this community and the ESMF core team, but I can't promise a lot of time to this right now.
Regarding the noarch: python
build: I don't know enough about this to give you a definite answer, and I think the same is true of others on the ESMF team. I'd say that, if it's passing your tests, then let's go ahead with it.
@conda-forge-admin, please rerender
@billsacks, we're all volunteers here so there's certainly no expectation of any time commitment. I've added you as a maintainer. We'll go ahead and give this a shot. @zklaus seems confident that this should work as expected and I trust his judgment.
Hi! This is the friendly conda-forge automerge bot!
I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)closes #69