conda-forge / esmpy-feedstock

A conda-smithy repository for esmpy.
BSD 3-Clause "New" or "Revised" License
6 stars 15 forks source link

Fix testing deps #75

Closed zklaus closed 1 year ago

zklaus commented 1 year ago

Checklist

Fixes #74.

This attempts to fix the dependencies ~by ignoring run_exports~ from packages that are purely used for testing in the build stage by patching pyproject.toml in line with the upstream patch https://github.com/esmf-org/esmf#116.

Turns out, ignoring run_exports was not necessary in this case, but patching pyproject.toml is, to ensure consistent environments downstream.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

zklaus commented 1 year ago

@conda-forge-admin, please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/esmpy-feedstock/actions/runs/5045676018.

valeriupredoi commented 1 year ago

great, cheers both @ocefpaf and @zklaus :beer: x2

maresb commented 1 year ago

Nice trick with patching the pyproject.toml, thanks a lot!

I was just able to remove a nasty hack where I installed an empty package named pytest-json-report to appease pip check.

I'll have to keep this technique in mind for other feedstocks.