Closed zklaus closed 1 year ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/esmpy-feedstock/actions/runs/5045676018.
great, cheers both @ocefpaf and @zklaus :beer: x2
Nice trick with patching the pyproject.toml
, thanks a lot!
I was just able to remove a nasty hack where I installed an empty package named pytest-json-report to appease pip check
.
I'll have to keep this technique in mind for other feedstocks.
Checklist
0
(if the version changed)~conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)Fixes #74.
This attempts to fix the dependencies ~by ignoring
run_exports
~ from packages that are purely used for testing in the build stage by patchingpyproject.toml
in line with the upstream patch https://github.com/esmf-org/esmf#116.Turns out, ignoring
run_exports
was not necessary in this case, but patchingpyproject.toml
is, to ensure consistent environments downstream.