search

conda-forge / f2c-feedstock

A conda-smithy repository for f2c.
BSD 3-Clause "New" or "Revised" License
2 stars 8 forks source link

Fixing license metadata to be SPDX compliant #17

Closed jakirkham closed 2 years ago

jakirkham commented 2 years ago

Currently the license metadata field says OTHER

https://github.com/conda-forge/f2c-feedstock/blob/d422b1d34e3aa065ac4a062d9fdc8791b9128317/recipe/meta.yaml#L41

This was likely set a while back before SPDX compliance became a requirement in conda-forge. Since this is not SPDX compliant, this linter has been raising about this ( https://github.com/conda-forge/f2c-feedstock/pull/13#issuecomment-1091015644 ).

If this is some form of already supported SPDX license, would be good to match the appropriate one from this list. Otherwise would recommend using LicenseRef-* for the appropriate custom license (like as is used here).

Areustle commented 2 years ago

There don't seem to be any matching SPDX licenses for AT&T or Bell(core/labs) that correspond to the License file.

There's a more-recent pair of Lucent Technologies Inc. licenses that seem to be a poor fit.

I propose using LicenseRef-AT&T-Bell-Attribution as attribution and no advertisement using company/personnel names are the only limitations, which is similar to the BSD-3-Clause-Attribution identifier.

jakirkham commented 2 years ago

cc @conda-forge/core (in case others have thoughts on how this case should be captured)

isuruf commented 2 years ago

SMLNJ is the correct one. https://spdx.org/licenses/SMLNJ.html

isuruf commented 2 years ago

Opened https://github.com/spdx/license-list-XML/issues/1441 to clarify a small change.

jakirkham commented 2 years ago

Wow that's a good find.

Thanks for raising that. Also was noticing that diff.