Change cmake virtual and real cuda arch flags to avoid extra JIT compilation

conda-forge / faiss-split-feedstock

A conda-smithy repository for faiss-split.

BSD 3-Clause "New" or "Revised" License

4 stars 15 forks source link

Change cmake virtual and real cuda arch flags to avoid extra JIT compilation #37

Closed dantegd closed 3 years ago

dantegd commented 3 years ago

Closes #36

See issue for a detailed description: https://github.com/conda-forge/faiss-split-feedstock/issues/36#issuecomment-797499145

Will be testing it later today to confirm issues are solved and will change from draft then (it just takes quite a while to compile the conda package locally).

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 3 years ago

LGTM (except we definitely need to bump the build number), but would appreciate @teju85's input on this

jakirkham commented 3 years ago

Edited OP to make sure the linked issue gets closed out. Hope that is ok 🙂

h-vetinari commented 3 years ago

Ping @teju85

I'm planning to merge this in the next 24h, but your feedback is still welcome even afterwards 🙃

h-vetinari commented 3 years ago

Thanks a lot @dantegd & @teju85 😊