Upgrade to version 2.4.0

mlund commented 4 years ago

Merge w. conda-forge

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mlund commented 4 years ago

@conda-forge-admin, please rerender

mlund commented 4 years ago

I'm getting the build errors below for both linux and macos; it looks a c++/stl issue. I can normally compile on these platforms (TravisCI), albeit a C++17 compiler is required (Clang 9 is definitely enough as is gcc 8). Any ideas how to fix this for this new version of faunus? ping @conda-forge/core

isuruf commented 4 years ago

it looks like a problem with c++/stl.

Are you sure? What's the error that you are getting?

mlund commented 4 years ago

OSX build

I am not sure it is STL, but for the osx build, the azure log points to the STL headers, or a mismatch between the compiler and Xcode:

In file included from /Users/runner/miniforge3/conda-bld/faunus_1590339407451/work/src/functionparser.cpp:1:
In file included from /Users/runner/miniforge3/conda-bld/faunus_1590339407451/work/src/functionparser.h:3:
In file included from /Users/runner/miniforge3/conda-bld/faunus_1590339407451/_build_env/bin/../include/c++/v1/string:504:
In file included from /Users/runner/miniforge3/conda-bld/faunus_1590339407451/_build_env/bin/../include/c++/v1/string_view:175:
In file included from /Users/runner/miniforge3/conda-bld/faunus_1590339407451/_build_env/bin/../include/c++/v1/__string:57:
In file included from /Users/runner/miniforge3/conda-bld/faunus_1590339407451/_build_env/bin/../include/c++/v1/algorithm:644:
/Users/runner/miniforge3/conda-bld/faunus_1590339407451/_build_env/bin/../include/c++/v1/functional:1416:29: error: 'operator delete' is unavailable: introduced in macOS 10.12
class _LIBCPP_EXCEPTION_ABI bad_function_call
                            ^
/Users/runner/miniforge3/conda-bld/faunus_1590339407451/_build_env/bin/../include/c++/v1/functional:1431:11: note: in implicit destructor for 'std::__1::bad_function_call' first required here
    throw bad_function_call();
          ^

Local development is usually done on osx or linux and I haven't seen this before.

Linux build (fixed)

On the Azure linux build with gcc 7.5 the following error occurs on the unittests target. I cannot reproduce this error using gcc 7.5 on my locla ubuntu installation.

/home/conda/feedstock_root/build_artifacts/faunus_1590339403185/work/src/unittests.cpp:20:
/home/conda/feedstock_root/build_artifacts/faunus_1590339403185/work/_deps/nanobench-src/src/include/nanobench.h: In member function 'bool ankerl::nanobench::detail::LinuxPerformanceCounters::monitor(uint32_t, uint64_t, ankerl::nanobench::detail::LinuxPerformanceCounters::Target)':
/home/conda/feedstock_root/build_artifacts/faunus_1590339403185/work/_deps/nanobench-src/src/include/nanobench.h:1529:25: error: 'PERF_EVENT_IOC_ID' was not declared in this scope
     if (-1 == ioctl(fd, PERF_EVENT_IOC_ID, &id)) {
                         ^~~~~~~~~~~~~~~~~

mlund commented 4 years ago

Applying a pre-build patch, the linux build now passes. I still do not know how to fix the macOS build. ping @conda-forge-admin

mlund commented 4 years ago

I suspect that the macOS SDK would need to be elevated from 10.9 to 10.12 and the issue seems related to this discussion.

isuruf commented 4 years ago

You need to rerender and add a run_constrained requirement as well. See https://conda-forge.org/docs/maintainer/knowledge_base.html#requiring-newer-macos-sdks

mlund commented 4 years ago

it looks like a problem with c++/stl.

Are you sure? What's the error that you are getting?

@isuruf Please see above. Can you think of a way to make the osx target work?

isuruf commented 4 years ago

Please remove the last commit and follow the instructions at https://conda-forge.org/docs/maintainer/knowledge_base.html#requiring-newer-macos-sdks

mlund commented 4 years ago

Please remove the last commit and follow the instructions at https://conda-forge.org/docs/maintainer/knowledge_base.html#requiring-newer-macos-sdks

Thanks a lot, this took the build almost to the end, but I now got an error regarding macOS 10.14 but still also 10.12 for the pyfaunus target. I will try to increase the SDK to 10.14 and if it doesn't work disable the python target for the osx build.

mlund commented 4 years ago

@conda-forge-admin, please rerender

mlund commented 4 years ago

@conda-forge-admin, please rerender

isuruf commented 4 years ago

Looks like you never rerendered before. So those changes were not reflected correctly. Can you try removing 10.14 and rerendering again?

mlund commented 4 years ago

Looks like you never rerendered before. So those changes were not reflected correctly. Can you try removing 10.14 and rerendering again?

@isuruf You mean go back to 10.12 or 10.9? There was a re-rendering 13 days ago (see above).

isuruf commented 4 years ago

to 10.12

mlund commented 4 years ago

@conda-forge-admin, please rerender

mlund commented 4 years ago

@isuruf Great, it now works with 10.12! Thanks for your support.

conda-forge / faunus-feedstock

Upgrade to version 2.4.0 #9

OSX build

Linux build (fixed)