search

conda-forge / fenics-feedstock

A conda-smithy repository for fenics.
BSD 3-Clause "New" or "Revised" License
13 stars 12 forks source link

Numpy version in conda environment #182

Open RemDelaporteMathurin opened 1 year ago

RemDelaporteMathurin commented 1 year ago

Hi,

I started noticing this warning when using the conda env:

/home/remidm/miniconda3/envs/fenicsproject/lib/python3.11/site-packages/ffc/uflacs/language/cnodes.py:1364: DeprecationWarning: `product` is deprecated as of NumPy 1.25.0, and will be removed in NumPy 2.0. Please use `prod` instead.
    sublist = build_initializer_lists(val, sizes[1:], level+1, formatter, padlen=padlen, precision=precision)

Numpy 1.25 is installed in the environment by default.

Should we add a requirement in the recipe?

minrk commented 1 year ago

an upper pin probably makes sense, assuming ffc will not get updated.

Because of the run_export, fenics-dolfin does already exclude numpy 2 because it is built with numpy 1. But ffc on its own does not.

RemDelaporteMathurin commented 1 year ago

I opened a PR to ffc and it got merged. Don't know when the fix will be released though.

RemDelaporteMathurin commented 1 year ago

@minrk not certain if this is still an issue, need to check. Anyway, I'm not sure where the upper requirement on numpy would go in this repository? not very familliar with conda recipes.