conda-forge / ffmpeg-feedstock

A conda-smithy repository for ffmpeg.
BSD 3-Clause "New" or "Revised" License
14 stars 45 forks source link

ffmpeg v6.0.0 #193

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/4289084496, please use this URL for debugging.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 1 year ago

Seems like we are hitting: https://stackoverflow.com/questions/75534136/new-ffmpeg-build-issue-libavcodec-aacps-tablegen-h-error-expected-declaration

hmaarrfk commented 1 year ago

I'm not sure how i feel about the 6.0 release.

http://www.ffmpeg.org/download.html#release_6.0 https://fosdem.org/2023/schedule/event/om_vlc/

Mostly, i'm worried that moving too fast at conda forge will leave alot of packages in a broken state without dual builds for ffmpeg 5.0 + 6.0.

Current migration status. image

hmaarrfk commented 1 year ago

we may need to revert https://github.com/FFmpeg/FFmpeg/commit/f8d6d0fbf12b3247a37885cd0a5cd32ddc1f01b3

hmaarrfk commented 1 year ago

@conda-forge-admin please rerender

@conda-forge-admin please restart cis

hmaarrfk commented 1 year ago

Mswindres seems to be giving problems.

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

hmaarrfk commented 1 year ago

lets add a pin to dav1d and a run export before we move forward

hmaarrfk commented 1 year ago

oh there is already a run export

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

hmaarrfk commented 1 year ago

Does anybody want to give this a quick lookover? I think this was pretty uneventful.

I do want to start a migration where both ffmpeg 5 and 6 get built.

Given their new release process, I think it is prudent.

If it is too much maintenance, we can revisit.

h-vetinari commented 1 year ago

I think this needs a rerender to pick up the pinning for dav1d, otherwise LGTM

hmaarrfk commented 1 year ago

@conda-forge-admin please rerender

hmaarrfk commented 1 year ago

Lets wait for comment for 1-2 days.

This would also allow the dav1d 1.2 migration to finish so rerendering this gets the latest version.

I just applied it eagerly. no need to wait on the account of dav1d.

hmaarrfk commented 1 year ago

@conda-forge-admin please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!