search

conda-forge / ffmpeg-feedstock

A conda-smithy repository for ffmpeg.
BSD 3-Clause "New" or "Revised" License
14 stars 45 forks source link

[v4.4.x] Rebuild for current pinnings #214

Closed h-vetinari closed 1 year ago

h-vetinari commented 1 year ago

Some feedstocks (esp. the hpp stack) are stuck on ffmpeg 4 because openscenegraph is not compatible with later ffmpeg versions, and likely never will be because the project reincarnated as vulkanscenegraph; switching all projects over to that is going to take a while, so rather than have permanent migration logjams, re-support v4.4 for a bit.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 1 year ago

@hmaarrfk, we seem to have lost the nvidia codecs here somehow:

+ ffmpeg -hide_banner -codecs
+ grep ' nvenc '

Would you have an idea what could be the cause of that? The recipe hasn't changed otherwise, except updating a few pins.

hmaarrfk commented 1 year ago

you likely want to pin to an older version of ffnvcodecs

hmaarrfk commented 1 year ago

The last successful build of 4.4.2 was in Dec 14, 2022, that would have gottten 11.1.5.2 https://github.com/conda-forge/ffnvcodec-headers-feedstock/pull/15

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 1 year ago

it is curious that you didn't have to pin svt-av1 https://github.com/conda-forge/ffmpeg-feedstock/blob/v5.x/recipe/meta.yaml#L63

hmaarrfk commented 1 year ago

feel free to merge if you aren't affraid of the SVT bug.

h-vetinari commented 1 year ago

it is curious that you didn't have to pin svt-av1

I did: https://github.com/conda-forge/ffmpeg-feedstock/pull/214/commits/18c789347822d2ef38351dd385fccdab08e5f84b

hmaarrfk commented 1 year ago

ah ok different styles.

Honestly, this stopped me from pushing merge on the HPP PR that I was reviewing.

Thanks for taking on the maintenance work on the 4.4x branch. happy to add it to the bot too.

ymontmarin commented 1 year ago

@hmaarrfk Yes I understand, I think I put a comment here: https://github.com/conda-forge/openscenegraph-feedstock/pull/32 on what to do to make the stack HPP ok despite with OSG dependency.

Thank you to both of you