Clarification on `--disable-videotoolbox` for OSX builds - Githubissues

conda-forge / ffmpeg-feedstock

A conda-smithy repository for ffmpeg.

BSD 3-Clause "New" or "Revised" License

14 stars 46 forks source link

Clarification on `--disable-videotoolbox` for OSX builds #241

Closed mmcauliffe closed 7 months ago

mmcauliffe commented 7 months ago

Comment:

With Qt 6.7, the default supported backed for Qt Multimedia has swapped to ffmpeg (https://doc.qt.io/qt-6/qtmultimedia-index.html#target-platform-and-backend-notes), so I was trying to get that working here: https://github.com/conda-forge/qt-main-feedstock/pull/256, but I'm running into an issue with missing symbols in ffmpeg libraries referring to Video Toolbox (_av_map_videotoolbox_format_to_pixfmt), which is explicitly disabled for this feedstock (https://github.com/conda-forge/ffmpeg-feedstock/blame/main/recipe/build.sh#L92).

It looks like was added in https://github.com/conda-forge/ffmpeg-feedstock/pull/122, but I'm wondering if there's any reason to not flip it to --enable_toolbox, it looks like it was explicitly taken out here: https://github.com/conda-forge/ffmpeg-feedstock/commit/ca8ee551bcbbd87c7ebdb839a75c8e7966c21078, but I'm not sure why.

h-vetinari commented 7 months ago

Closing as resolved by #242