conda-forge / ffmpeg-feedstock

A conda-smithy repository for ffmpeg.
BSD 3-Clause "New" or "Revised" License
14 stars 44 forks source link

license mismatch #264

Closed rsxdalv closed 2 months ago

rsxdalv commented 2 months ago

License here is listed as LGPL while https://anaconda.org/conda-forge/ffmpeg lists it as License: GPL-2.0-or-later

h-vetinari commented 2 months ago

The anaconda overview can only list one license per package, but here we're explicitly building packages with two different licenses. If you install ffmpeg=*=lgpl*, you get the LGPL one; if you install ffmpeg=*=gpl*, you get the GPL one. See https://github.com/conda-forge/ffmpeg-feedstock/blob/a752e5b6dc8f9b4678af44498e3b961fbd9e7ee1/recipe/meta.yaml#L175-L176

h-vetinari commented 2 months ago

You can also inspect this per-artefact under https://anaconda.org/conda-forge/ffmpeg/files, by clicking on the ℹ️ button.

rsxdalv commented 2 months ago

Got it, thanks for the clarification.

Though the installation section does not mention it; maybe this is a common pattern but I have never seen it before with conda.

No mention of license-based installation here:

Installing ffmpeg
Installing ffmpeg from the conda-forge channel can be achieved by adding conda-forge to your channels with:

conda config --add channels conda-forge
conda config --set channel_priority strict
Once the conda-forge channel has been enabled, ffmpeg can be installed with conda:

conda install ffmpeg
or with mamba:

mamba install ffmpeg
It is possible to list all of the versions of ffmpeg available on your platform with conda:

conda search ffmpeg --channel conda-forge
or with mamba:

mamba search ffmpeg --channel conda-forge
Alternatively, mamba repoquery may provide more information:

# Search all versions available on your platform:
mamba repoquery search ffmpeg --channel conda-forge

# List packages depending on `ffmpeg`:
mamba repoquery whoneeds ffmpeg --channel conda-forge

# List dependencies of `ffmpeg`:
mamba repoquery depends ffmpeg --channel conda-forge
h-vetinari commented 2 months ago

Yes, that part of the readme is auto-generated for every feedstock from the package names, and does not (realistically: cannot) take into account all variants that may exist for some of our more complicated packages.

rsxdalv commented 1 month ago

For information - When I try to install, it takes a very long time, I tried and it seemed to just stop, so I had to try again but it is very very slow:

conda install --dry-run -y -k conda-forge::ffmpeg=*=gpl*
Collecting package metadata (current_repodata.json): done
Solving environment: failed with initial frozen solve. Retrying with flexible solve.
Solving environment: failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: -
conda install --dry-run -y -k conda-forge::ffmpeg=4.4.2=lgpl*
Collecting package metadata (current_repodata.json): done
Solving environment: failed with initial frozen solve. Retrying with flexible solve.
Solving environment: failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: done

==> WARNING: A newer version of conda exists. <==
  current version: 23.1.0
  latest version: 24.7.1

Please update conda by running

    $ conda update -n base -c defaults conda

Or to minimize the number of packages updated during conda update use

     conda install conda=24.7.1

## Package Plan ##

  environment location: C:\Users\admin\Desktop\one-click-installers-tts-main\installer_files\env

  added / updated specs:
    - conda-forge::ffmpeg==4.4.2[build=lgpl*]

The following packages will be downloaded:

    package                    |            build
    ---------------------------|-----------------
    aom-3.6.1                  |       h63175ca_0         7.6 MB  conda-forge
    expat-2.6.2                |       hd77b12b_0         260 KB
    ffmpeg-4.4.2               | lgpl_hf152e9b_13        10.3 MB  conda-forge
    font-ttf-dejavu-sans-mono-2.37|       hd3eb1b0_0         335 KB
    font-ttf-inconsolata-2.001 |       hcb22688_0          83 KB
    font-ttf-source-code-pro-2.030|       hd3eb1b0_0         654 KB
    font-ttf-ubuntu-0.83       |       h8b1ccd4_0         1.5 MB
    fontconfig-2.14.2          |       hbde0cde_0         186 KB  conda-forge
    fonts-anaconda-1           |       h8fa9717_0           3 KB
    fonts-conda-ecosystem-1    |       hd3eb1b0_0           5 KB
    libiconv-1.17              |       hcfcfb64_2         621 KB  conda-forge
    libxml2-2.13.1             |       h24da03e_1         2.9 MB
    libzlib-1.2.13             |       h2466b09_6          55 KB  conda-forge
    openh264-2.3.1             |       h63175ca_2         401 KB  conda-forge
    svt-av1-1.4.1              |       h63175ca_0         1.9 MB  conda-forge
    ucrt-10.0.20348.0          |       haa95532_0         531 KB
    vc14_runtime-14.40.33810   |      ha82c5b3_20         734 KB  conda-forge
    vs2015_runtime-14.40.33810 |      h3bf8584_20          17 KB  conda-forge
    zlib-1.2.13                |       h2466b09_6         105 KB  conda-forge
    ------------------------------------------------------------
                                           Total:        28.0 MB

The following NEW packages will be INSTALLED:

  aom                conda-forge/win-64::aom-3.6.1-h63175ca_0
  expat              pkgs/main/win-64::expat-2.6.2-hd77b12b_0
  font-ttf-dejavu-s~ pkgs/main/noarch::font-ttf-dejavu-sans-mono-2.37-hd3eb1b0_0
  font-ttf-inconsol~ pkgs/main/noarch::font-ttf-inconsolata-2.001-hcb22688_0
  font-ttf-source-c~ pkgs/main/noarch::font-ttf-source-code-pro-2.030-hd3eb1b0_0
  font-ttf-ubuntu    pkgs/main/noarch::font-ttf-ubuntu-0.83-h8b1ccd4_0
  fontconfig         conda-forge/win-64::fontconfig-2.14.2-hbde0cde_0
  fonts-anaconda     pkgs/main/noarch::fonts-anaconda-1-h8fa9717_0
  fonts-conda-ecosy~ pkgs/main/noarch::fonts-conda-ecosystem-1-hd3eb1b0_0
  libiconv           conda-forge/win-64::libiconv-1.17-hcfcfb64_2
  libxml2            pkgs/main/win-64::libxml2-2.13.1-h24da03e_1
  libzlib            conda-forge/win-64::libzlib-1.2.13-h2466b09_6
  openh264           conda-forge/win-64::openh264-2.3.1-h63175ca_2
  svt-av1            conda-forge/win-64::svt-av1-1.4.1-h63175ca_0
  ucrt               pkgs/main/win-64::ucrt-10.0.20348.0-haa95532_0
  vc14_runtime       conda-forge/win-64::vc14_runtime-14.40.33810-ha82c5b3_20

The following packages will be UPDATED:

  ffmpeg                     pytorch::ffmpeg-4.3-ha925a31_0 --> conda-forge::ffmpeg-4.4.2-lgpl_hf152e9b_13
  vs2015_runtime     pkgs/main::vs2015_runtime-14.29.30133~ --> conda-forge::vs2015_runtime-14.40.33810-h3bf8584_20
  zlib                    pkgs/main::zlib-1.2.13-h8cc25b3_0 --> conda-forge::zlib-1.2.13-h2466b09_6

DryRunExit: Dry run. Exiting.

This took around 10-20 minutes? Meanwhile I can do --dry-run for other packages in a minute or two.

rsxdalv commented 1 month ago

Alright, it seems like for new environments it does not take such an outstanding amount of time and is only a problem for existing environments & using the * builds. I do wish there was a more direct way of distinguishing the different ffmpegs but this should work out.

h-vetinari commented 1 month ago
==> WARNING: A newer version of conda exists. <==
  current version: 23.1.0
  latest version: 24.7.1

If you update your conda (or use mamba or pixi), you should get a faster solver.

I do wish there was a more direct way of distinguishing the different ffmpegs but this should work out.

What do you mean by distinguish? If it's the selection itself, you may be interested in https://github.com/conda/conda/issues/11053

rsxdalv commented 1 month ago

Yep, https://github.com/conda/conda/issues/11053 is what I want.

On Sun, Jul 28, 2024, 11:16 PM h-vetinari @.***> wrote:

==> WARNING: A newer version of conda exists. <== current version: 23.1.0 latest version: 24.7.1

If you update your conda (or use mamba or pixi), you should get a faster solver.

I do wish there was a more direct way of distinguishing the different ffmpegs but this should work out.

What do you mean by distinguish? If it's the selection itself, you may be interested in conda/conda#11053 https://github.com/conda/conda/issues/11053

— Reply to this email directly, view it on GitHub https://github.com/conda-forge/ffmpeg-feedstock/issues/264#issuecomment-2254632569, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTRXI4SZ4EBX4AUYPDDLJTZOVGQNAVCNFSM6AAAAABKSUAS42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGYZTENJWHE . You are receiving this because you authored the thread.Message ID: @.***>