Add importlib-metadata dependency for python<3.8

conda-forge / filesystem-spec-feedstock

A conda-smithy repository for filesystem-spec.

BSD 3-Clause "New" or "Revised" License

2 stars 9 forks source link

Add importlib-metadata dependency for python<3.8 #45

Closed zklaus closed 3 years ago

zklaus commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Fixes #42

importlib-metadata is a dependency that is not required from Python 3.8 onward since then it is already part of Python itself. However, to avoid problems, particularly with entry_point resolution in downstream packages, it should be added as a dependency for older Python versions.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

zklaus commented 3 years ago

@conda-forge-admin, please rerender

maresb commented 3 years ago

Unfortunately it's not so simple. You can't use any version selectors with noarch.

From what I've gathered, it seems to be accepted practice at conda-forge to add an importlib-metadata dependency for all Python versions in order to stay noarch.

zklaus commented 3 years ago

Thanks for having a look @maresb! Perhaps it is even simpler here, since upstream-upstream this seems to have been addressed.

@martindurant, I see that in this package your repo is given as the homepage, but that is a fork of intake which seems to be upstream. Indeed, your master branch is behind the current release 0.9.0 and the issue of importlib-metadata dependency has been resolved in upstream recently.

Could you clarify what is actually upstream? Should we change the homepage to the intake repo?
Would it be sensible to adopt the change in importlib-metadata dependency handling as a patch in the current package?

PS: The relevant commit is intake/filesystem_spec@70d8dba2a5f6a41debe3aa332dd8ff0886c3d894.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

zklaus commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

martindurant commented 3 years ago

This is fine, but I will shortly be releasing a new version anyway.

zklaus commented 3 years ago

Great. What about the homepage?

martindurant commented 3 years ago

Yes, that should be updated to /intake/

zklaus commented 3 years ago

@conda-forge-admin, please rerender