search

conda-forge / filesystem-spec-feedstock

A conda-smithy repository for filesystem-spec.
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

Create package variants for pip-extras? #60

Open h-vetinari opened 2 years ago

h-vetinari commented 2 years ago

I see that fsspec comes with a wide variety of extra-installs.

These could be made available in conda-forge, where generally the suggested mapping would be: pip conda
foo[extra] foo-extra

An example can be seen on the gym feedstock, though there are more.

WDYT @conda-forge/filesystem-spec?

martindurant commented 2 years ago

I am aware that many packages on conda-forge take the "include everything" approach, but I don't think this is appropriate for fsspec, which ought to be available in minimalist form. Fsspec is commonly included in small environments on limited resources systems (e.g., aws lambda, which will already have botocore around), and the set of possible helper packages is rather large (e.g., hdfs!).

h-vetinari commented 2 years ago

fsspec, which ought to be available in minimalist form

I'm not saying that the minimal version shouldn't remain available, but that additionally the other outputs specified upstream become available.

Apart from just having the ease of use, I've also seen this used (wrongly!) in conda requirements like so:

  - fsspec[http]

which doesn't work as expected, and also doesn't warn unfortunately.

martindurant commented 2 years ago

Ah, so you mean a separate (meta)package like "fsspec-complete"? That could be done, but it wouldn't stop anyone from using incorrect conda syntax like above!