conda-forge / filesystem-spec-feedstock

A conda-smithy repository for filesystem-spec.
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

Python 3.6 support should be dropped #63

Closed maartenbreddels closed 1 year ago

maartenbreddels commented 2 years ago

Hi,

I see in CI:

I think Python 3.6 was delisted in setup.py in https://github.com/fsspec/s3fs/pull/582/commits/a0e31dc81a5d9a0055dd1d5500d7a6adafd30a3d but not in the recipe

not sure which version started this.

martindurant commented 2 years ago

You are quite right, py36 should not have been built. I suppose we need a patch?

maartenbreddels commented 2 years ago

See also https://github.com/jupyter/nbclient/issues/194 to mark a package as broken

candalfigomoro commented 1 year ago

I confirm that the conda package (the original build) for version 2023.3.0 is broken with Python 3.7 because this change made Python >=3.8 mandatory: https://github.com/fsspec/filesystem_spec/commit/bec9a8d6e5962da4cc2473c8c7924f002033fad3

If you run version 2023.3.0 with Python 3.7 you get this error: ModuleNotFoundError: No module named 'importlib.metadata'

Version 2023.1.0 is the last version compatible with Python <3.8