Set min python to 3.8 - Githubissues

conda-forge / filesystem-spec-feedstock

A conda-smithy repository for filesystem-spec.

BSD 3-Clause "New" or "Revised" License

2 stars 9 forks source link

Set min python to 3.8 #76

Closed ianthomas23 closed 1 year ago

ianthomas23 commented 1 year ago

Fixes #75.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

martindurant commented 1 year ago

I keep getting this wrong :|

Unfortunately this won't be enough, we need to patch the metadata on the existing build

martindurant commented 1 year ago

@conda-forge-admin , what do I need to do to update the python required version on the build that already went out? Or simply removing that build would be fine.

hoxbro commented 1 year ago

I think you meant to call @conda-forge/core

ianthomas23 commented 1 year ago

There is some info at https://conda-forge.org/docs/maintainer/updating_pkgs.html#maint-fix-broken-packages about how to do this. As we only need to patch the metadata, I think we only need to create a PR on conda-forge-repodata-patches-feedstock. There is a recent example of changing the minimum python version in this PR: https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/pull/407/files