conda-forge / fiona-feedstock

A conda-smithy repository for fiona.
BSD 3-Clause "New" or "Revised" License
8 stars 16 forks source link

Rebuild for new fontconfig macOS dylib compatibility version #191

Closed martinfleis closed 2 years ago

martinfleis commented 2 years ago

I believe that rebuilding Fiona should resolve current installation issues on macOS (see https://github.com/conda-forge/fontconfig-feedstock/issues/54 and https://github.com/conda-forge/fontconfig-feedstock/pull/53#issuecomment-1062456875) and the issue itself for example in https://github.com/geopandas/geopandas/runs/5699959207?check_suite_focus=true

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

akrherz commented 2 years ago

@conda-forge-admin please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

jorisvandenbossche commented 2 years ago

It seems this rebuild has caused import issues -> https://github.com/conda-forge/fiona-feedstock/issues/192

jorisvandenbossche commented 2 years ago

I am also not sure if we actually run tests on Windows, at least the log does not have any output for the test step: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=481521&view=logs&j=00f5923e-fdef-5026-5091-0d5a0b3d5a2c&t=3cc4a9ed-60e1-5810-6eb3-5f9cd4a26dba&l=1252 (while eg on Mac you see the output of pytest)

dopplershift commented 2 years ago

@jorisvandenbossche It would seem the tests for Windows are currently commented out 😒

https://github.com/conda-forge/fiona-feedstock/blob/8e724f2f2c619ce39c19c6dfd7ee8df6f138cf7e/recipe/run_test.bat#L6-L7

jorisvandenbossche commented 2 years ago

Ah, that's the "REM" ..

Would it be possible to "cancel" the latest build so people would still get the previous working one, until we figure out the reason?

dopplershift commented 2 years ago

Open a PR here to mark the bad packages as "broken".