search

conda-forge / fiona-feedstock

A conda-smithy repository for fiona.
BSD 3-Clause "New" or "Revised" License
8 stars 16 forks source link

Rebuild for gdal35 #197

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

This PR has been triggered in an effort to update gdal35.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2394927839, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

akrherz commented 2 years ago

Maybe Toblerity/Fiona#1099 is related? Maybe need to wait for fiona 1.9.0 ? Not fully sure

jorisvandenbossche commented 2 years ago

I think we can skip that failing test (test_drvsupport.py::test_no_append_driver_cannot_append[FlatGeobuf]). It's not a fix in Fiona we would need to wait for (so fiona 1.8 can already work with GDAL 3.5, no need to wait for fiona 1.9, AFAIK), but it was a bug in GDAL that should be fixed in 3.5.1.

akrherz commented 2 years ago

The windows (which does not run tests yet with #195) failure is unrelated it seems

  File "C:\Miniconda\lib\site-packages\conda_build\utils.py", line 2084, in linked_data_no_multichannels
    from conda.common.compat import itervalues
ImportError: cannot import name 'itervalues' from 'conda.common.compat' (C:\Miniconda\lib\site-packages\conda\common\compat.py)

I'll push the suggested test skip now to see how it goes.

akrherz commented 2 years ago

Sweet, green PR @jorisvandenbossche

jorisvandenbossche commented 2 years ago

Thanks!