search

conda-forge / fiona-feedstock

A conda-smithy repository for fiona.
BSD 3-Clause "New" or "Revised" License
8 stars 16 forks source link

Rebuild for libgdal36 #202

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

This PR has been triggered in an effort to update libgdal36.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3481341888, please use this URL for debugging.

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was not passing and not merged.

rouault commented 1 year ago

cf https://github.com/Toblerity/Fiona/pull/1162 for a proposed patch to address GDAL 3.6.0 compatibility

zklaus commented 1 year ago

The PR mentioned by @rouault has been superseded by Toblerity/Fiona#1122. Are we waiting for a new Fiona release then?

rbuffat commented 1 year ago

This PR does not change the functionality of Fiona (expect that without it Fiona limits some driver capabilities that GDAL gained with version 3.6)

The failing tests here are tests that test GDAL functionality. E.g. can a driver append or write. If such a test fails, it does not mean that Fiona will not work. But only that Fiona limits GDAL functionality unnecessarily. All tests marked with @pytest.mark.gdal in https://github.com/Toblerity/Fiona/pull/1122/files can be safely ignored.

CC @sgillies

zklaus commented 1 year ago

I tried to port the patch in #203, but it didn't quite work. @rbuffat, perhaps you would have some insight? I don't understand the log message.

zklaus commented 1 year ago

I think I got it in #203. The issue was that in addition to the backported patch, there was a patch needed to fix the extension of the newly allowed OpenFileGDB, which did not come with the original backported patch because in Fiona 1.9 the whole metadata system for determining the extensions changed.

Feel free to pluck the commits from #203.

zklaus commented 1 year ago

@conda-forge/fiona, if you prefer, you can add me as a maintainer and I will take care of it.

akrherz commented 1 year ago

Thanks @zklaus , can't we just take #203 as it is?

zklaus commented 1 year ago

Yes, @akrherz, that should work. Thanks for taking care.

regro-cf-autotick-bot commented 1 year ago

Due to the bot-rerun label I'm closing this PR. I will make another one as appropriate. This was generated by https://github.com/regro/autotick-bot/actions/runs/3686473156