conda-forge / flaml-feedstock

A conda-smithy repository for flaml.
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Source tests from FLAML repository #9

Closed MichalChromcak closed 2 years ago

MichalChromcak commented 2 years ago

Checklist

Needs FLAML PR 309 to be merged and release to be made before merging this one.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

MichalChromcak commented 2 years ago

Issue: the current .tar.gz distribution does not contain all the tests (e.g. test/nlp folder) - only test_autovw.py and test_version.py

image

image

@sonichi, @shao-kun-zhang Shall test_conda.py be brought to the topmost level to not copy all the tests and drag them in the distribution or shall there be a full test suite available?

sonichi commented 2 years ago

Issue: the current .tar.gz distribution does not contain all the tests (e.g. test/nlp folder) - only test_autovw.py and test_version.py

image

image

@sonichi, @Shao-kun-Zhang Shall test_conda.py be brought to the topmost level to not copy all the tests and drag them in the distribution or shall there be a full test suite available?

I suggest bringing to the top level.

MichalChromcak commented 2 years ago

Note: the last checks are expected to fail until new release is made. Once available, the new version number should be set in meta.yaml