Occt variants - Githubissues

conda-forge / freecad-feedstock

A conda-smithy repository for freecad.

BSD 3-Clause "New" or "Revised" License

7 stars 22 forks source link

Occt variants #113

Closed looooo closed 7 months ago

looooo commented 7 months ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 7 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

looooo commented 7 months ago

@adrianinsaval sorry for pushing to FreeCAD/freecad-feedstock . Somehow my fork was directing to this repository. Feel free to delete the branch once this PR is merged.

looooo commented 7 months ago

no idea why some builds are failing. Something about pyside2 packages:

KeyError: Dist(channel='conda-forge', dist_name='pyside2-5.15.8-py310h1570d6a_3', name='pyside2', fmt='.conda', version='5.15.8', build_string='py310h1570d6a_3', build_number=3, base_url=None, platform=None)

any ideas what that can be @conda-forge/pyside2

adrianinsaval commented 7 months ago

tbh I think we can just keep it with occt 7.6.3 only until next release, I hope we can fix 7.7 problems by then. I don't oppose merging this though, so if you think it's worth doing go ahead and merge! I've been facing those weird KeyError problems many times lately, it seems to happen at random, running CI again on the exact same code may succeed at a different time.

@adrianinsaval sorry for pushing to FreeCAD/freecad-feedstock . Somehow my fork was directing to this repository. Feel free to delete the branch once this PR is merged.

that probably happened because that used to be your personal fork that then got transferred to the org account. Right now https://github.com/looooo/freecad-feedstock redirects to https://github.com/FreeCAD/freecad-feedstock, I guess you need to fork again for the redirect to stop

looooo commented 7 months ago

tbh I think we can just keep it with occt 7.6.3 only until next release, I hope we can fix 7.7 problems by then. I don't oppose merging this though, so if you think it's worth doing go ahead and merge! I've been facing those weird KeyError problems many times lately, it seems to happen at random, running CI again on the exact same code may succeed at a different time.

In my mind we should align with Conda-forge-pinning which currently is at occt 7.7. But we can keep occt 7.6.3 if needed, (maybe supporting only some python versions to make the build-matrix smaller)

adrianinsaval commented 7 months ago

maybe we can just move conda-forge to occt 7.7, for people who encounter occt problems they can move to the freecad channel where I'm going to keep occt 7.6.3+py 3.10 builds