Install the pkg-config file on Windows too.

conda-forge / freetype-feedstock

A conda-smithy repository for freetype.

BSD 3-Clause "New" or "Revised" License

0 stars 15 forks source link

Install the pkg-config file on Windows too. #22

Closed pkgw closed 6 years ago

pkgw commented 6 years ago

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pkgw commented 6 years ago

Crap, should not be merged just yet. There's a problem with conda-build rewriting the paths in the pkg-config files correctly, I think because they used mixed-style ("C:/foo/bar") Windows paths.

ocefpaf commented 6 years ago

Crap, should not be merged just yet. There's a problem with conda-build rewriting the paths in the pkg-config files correctly, I think because they used mixed-style ("C:/foo/bar") Windows paths.

OK. Pinging @msarahan and @mingwandroid here for advice.

pkgw commented 6 years ago

Reading conda-build, it looks like it does handle all the variant ways that Windows paths might be stored as text. Maybe an issue with capitalization changing? Investigating ...

pkgw commented 6 years ago

Yes, I think it's because the capitalization of the path is different in the generated file than what conda-build knows. In principle I think conda-build could handle this, but it sure sounds like that would be a hassle. I'll see if I can figure out some workarounds.

pkgw commented 6 years ago

Ah. In particular, CMake seems to like to decapitalize all of the paths that it processes on Windows. So if you ever switched to building things in C:\BLD rather than C:\bld, I think that suddenly many Windows packages would start breaking in exciting ways.

pkgw commented 6 years ago

OK, I've convinced myself that everything stays in order if you build your packages in the right prefix. In which case I think this PR is ready for review.