search

conda-forge / freetype-feedstock

A conda-smithy repository for freetype.
BSD 3-Clause "New" or "Revised" License
0 stars 15 forks source link

tighten pinning to X.X? #28

Open grlee77 opened 5 years ago

grlee77 commented 5 years ago

Issue:

A user is reporting an issue with VTK (conda-forge/vtk-feedstock#80) when freetype 2.10 is used. It seems that the package was built using the pinned release 2.9.1 bu this pinning is not enforced by the VTK package.

The following site seems to indicate changes in symbols between these versions: https://abi-laboratory.pro/?view=timeline&l=freetype

Should we make run exports tighter here?: https://github.com/conda-forge/freetype-feedstock/blob/650156e522bc712bcdd9c6b1a9281b3b444bbade/recipe/meta.yaml#L17-L19

And if so, does this need to also be changed here or can that be safely ignored at this point?: https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/9b8e67fcac4a4199dc7af7f120564aceab1cc7b8/recipe/conda_build_config.yaml#L177-L178

ocefpaf commented 5 years ago

The right place to discuss this is at conda-forge/conda-forge-pinning-feedstock

And if so, does this need to also be changed here or can that be safely ignored at this point?: conda-forge/conda-forge-pinning-feedstock:recipe/conda_build_config.yaml@9b8e67f#L177-L178

I prefer if we change in both because not all packages are ready for run_exports yet.

hmaarrfk commented 5 years ago

We just had an other issue report a similar issue with opencv https://github.com/conda-forge/opencv-feedstock/issues/174

hmaarrfk commented 5 years ago

That said, they had a mixed environment, default + conda-forge and it was likely due to that rather than the freetype pinning.

i just tested opencv 4.1.1 (built with freetype 2.10) and freetype 2.9 and it works as expected.

hmaarrfk commented 5 years ago

So I built up a test for OpenCV to verify a user's problem, and unfortunately, it seems that on OSX, the 2.9 build is incompatible with the 2.10 build. https://github.com/conda-forge/opencv-feedstock/pull/175

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=59165