search

conda-forge / freetype-feedstock

A conda-smithy repository for freetype.
BSD 3-Clause "New" or "Revised" License
0 stars 15 forks source link

Windows cmake & pkgconfig files are wrong because of include dir move #40

Open wolfv opened 3 years ago

wolfv commented 3 years ago

Because of these MOVE commands here, the cmake config and pkgconfig include dirs don't match on Windows.

https://github.com/conda-forge/freetype-feedstock/blob/9950c93dee255db13490f787eae3c19642f1450a/recipe/bld.bat#L35-L38

Not sure why this is necessary, but I am wondering if we could patch the cmake files? Or remove this move?

ocefpaf commented 3 years ago

Not sure why this is necessary, but I am wondering if we could patch the cmake files? Or remove this move?

I don't remember exactly but some packages expected it "one level down." Ideally we should patch cmake as you said.

hmaarrfk commented 2 years ago

Truthfully, I think that the issue is that many packages for windows did not use pkgconfig or cflags correctly. I would suggest removing these move commands altogether and helping downstream packages use the correctly library flags.

I don't think we want to change the organization compared to unix where the files are stored under the subdirectory freetype2.