Closed regro-cf-autotick-bot closed 2 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@Marco-Sulla Just to explain what I'm doing to update the PRs:
# Copy instructions from "Merging via command line" on the PR
git checkout -b regro-cf-autotick-bot-2.0.6_h7851a9 master
git pull https://github.com/regro-cf-autotick-bot/frozendict-feedstock.git 2.0.6_h7851a9
# cherry-pick commit from previous branch that contains changes
git cherry-pick fd79ad351f8eb2facd7eaa6237716ba1239c703b
# update PR by pushing to repository of bot (any maintainer can do this)
git push -u regro-bot regro-cf-autotick-bot-2.0.6_h7851a9:2.0.6_h7851a9
Then, since the commit changes the package from noarch
to a package that needs to be compiled for all platforms individually, I request a "re-render"
@conda-forge-admin , please rerender
python 3.6 is required. Frozendict does not work with older versions.
That is a conda-forge quirk - for noarch
packages, a minimal python version is specified via the python package dependency.
Here, I would do this using the skip
field of the build.
However, conda-forge anyhow only builds packages for python 3.6 - 3.9 currently
PS: if you add py
after setup.py
, a pure python package is created.
if you add
py
aftersetup.py
, a pure python package is created.
Can you elaborate on this? What would we need to change in the meta.yaml
to build the pure python package?
Maybe it's possible to do this just for windows if we can't figure out the compile issues (sorry, I'm not working on windows either - in principle you may be able to use the build-locally.py
script to run the tests locally via docker, which should make iterations easier and quicker. I tried this once for another package and there it didn't work for me but maybe worth giving a shot.)
Ok, I found the new problem with win builds.
The problem is ssize_t
is not defined in MSVC
. This not make me surprised.
The BIG problem is that HAVE_SSIZE_T
is declared by default in pyconfig.h
. BUT this file can be overwritten by ./configure
(see pyconfig.h.in
and how is used)
Could you be so kind to pass me the pyconfig.h
generated by a configure
by MSVC
?
Hm... I guess that would mean we need to provide custom build scripts (build.sh
) and I haven't looked into how to do this
for python packages yet.
Would it be possible to add a workaround for this in the code with some ifdef?
There is no need to make a new release; it's easy to apply a diff patch in the meta.yaml
.
Would it be possible to add a workaround for this in the code with some ifdef?
I would be more secure to have the pyconfig.h
generated by a configure
by MSVC
. pyconfig.h
have a lot of defines and I don't know what are undefined by the configure
on windows. You should check the pyconfig.h
under the build folder, if it's separate from the source code folder.
There is no need to make a new release; it's easy to apply a diff patch in the
meta.yaml
.
I need to update the Pypi package, sorry :(
It is very likely that the current package version for this feedstock is out of date. Notes for merging this PR:
license_file
is packagedNote that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
NEW: If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</code
please add bot automerge
in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!Closes: #10
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever
) and pip (pip install re-ver
) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1130168444, please use this URL for debuggingDependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: false
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis of the source code shows no discrepancy between the library's imports and the package's stated requirements in the meta.yaml.