conda-forge / frozendict-feedstock

A conda-smithy repository for frozendict.
BSD 3-Clause "New" or "Revised" License
0 stars 9 forks source link

Added noarch build #25

Closed Marco-Sulla closed 2 years ago

Marco-Sulla commented 2 years ago
conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Marco-Sulla commented 2 years ago

Mh. This time the checks passed, but I'm not sure about the result:

INFO :: The inputs making up the hashes for the built packages are as follows:
{
  "frozendict-2.2.1-py310h6acc77f_1": {
    "recipe": {
      "c_compiler": "gcc",
      "c_compiler_version": "9",
      "channel_targets": "conda-forge main",
      "python": "3.10.* *_cpython",
      "target_platform": "linux-64"
    }
  },
  "frozendict-noarch-2.2.1-py310hff52083_1": {
    "recipe": {
      "channel_targets": "conda-forge main",
      "python": "3.10.* *_cpython",
      "target_platform": "linux-64"
    }
  }
}

It seems that noarch was packaged for every platform. It should not, since is platform independent.

I know that exists a noarch option. Maybe do I have to use it?

ltalirz commented 2 years ago

I know that exists a noarch option. Maybe do I have to use it?

I would suggest to, yes