search

conda-forge / frozendict-feedstock

A conda-smithy repository for frozendict.
BSD 3-Clause "New" or "Revised" License
0 stars 9 forks source link

MNT: rerender #4

Closed conda-forge-linter closed 5 years ago

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I've rerendered the recipe as instructed in #3.

Here's a checklist to do before merging.

Fixes #3

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ltalirz commented 5 years ago

@tkelman Just for me to understand: is this just about re-rendering the feedstock? In this case, bumping the build number would seem like the right thing to do...

tkelman commented 5 years ago

Yep, we're noticing no build is available for python 3.7 which was causing some downstream issues in the autotick bot that happens to depend on this package (but is understandable given there hasn't been a new release of this package since before python 3.7 came out). I believe rerendering should fix that, and you're correct that bumping the build number would be a good idea since the upstream package version isn't changing. Thanks for the quick response!

ltalirz commented 5 years ago

Let me know in case any problems remain

tkelman commented 5 years ago

Will do! Now I'm seeing why there wasn't a noarch build of this available, the merge commit for #2 failed on circle (https://circleci.com/gh/conda-forge/frozendict-feedstock/5?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link) due to an out of date token, the token update commit had [ci skip], and there hadn't been any other commits until just now.