Add pip check, some build_number math

conda-forge / frozendict-feedstock

A conda-smithy repository for frozendict.

BSD 3-Clause "New" or "Revised" License

0 stars 9 forks source link

Add pip check, some build_number math #50

Closed bollwyvl closed 11 months ago

bollwyvl commented 11 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bollwyvl commented 11 months ago

@conda-forge-admin please rerender

github-actions[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/frozendict-feedstock/actions/runs/7090581301.

erykoff commented 11 months ago

I don't know if I should comment on this PR or (probably) make a new issue, but the current meta.yaml seems to be giving incorrect outputs. You can't mix noarch and arch with the same output name, and noarch can't have python constraints. Now the frozendict 2.3.10 installation seems to always give noarch, and built with 3.12 so it doesn't work right with 3.11. I think we'd need a different output name? (Not sure, this is beyond my depth except to say that we're not getting the right file)

bollwyvl commented 11 months ago

Yep, sorry, was just trying some things. Basically, downstream, I'm getting:

the noarch package when there exists a (presumably better) platform/python-specific version
some shouty DEPRECATED warnings during pip check about the .egg that ends up from the setup.py install

Perhaps a re-render on main would decrease the noise.

beckermr commented 11 months ago

You can build noarch on a more recent python than what you run on. Something else happened which I cannot quite figure out.

beckermr commented 11 months ago

@Marco-Sulla Why does the noarch build contain a python .egg and not a straight copy of the source like I am more familiar with?

beckermr commented 11 months ago

Tbh I don't think having noarch and arch builds for the same package makes sense. Noarch will always be picked since it comes really high in the solver priority.

bollwyvl commented 11 months ago

Welp, in the interim, I've worked around depending on this package by paring down some other deps, so will close this... good luck!

Marco-Sulla commented 11 months ago

Tbh I don't think having noarch and arch builds for the same package makes sense. Noarch will always be picked since it comes really high in the solver priority.

This is not how pip works. I do not really understand the sense of giving higher priority to noarch.

beckermr commented 11 months ago

Yeah conda is not pip. This preference reduces the sizes of conda installs, but in general IDK why it is that way.