2.2.1 release with SCons build instead of pip - Githubissues

conda-forge / galsim-feedstock

A conda-smithy repository for galsim.

BSD 3-Clause "New" or "Revised" License

0 stars 7 forks source link

2.2.1 release with SCons build instead of pip #11

Closed brianv0 closed 5 years ago

brianv0 commented 5 years ago

Checklist

[X] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[X] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

This is 2.2.1 release build with a SCons based build instead of pip so we can get a shared library.

closes #10 closes #9 closes #8

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

beckermr commented 5 years ago

you didn't commit the build script

beckermr commented 5 years ago

You can run the linux builds in a docker container locally (or on your local linux box if you do it that way.) It might save you some time waiting on azure.

beckermr commented 5 years ago

You’ll need to use a pin_compatible statement for numpy in the run section but we can fix this later.

beckermr commented 5 years ago

I am worried about this error from the conda linking stuff:

ERROR (galsim,lib/python3.6/site-packages/galsim/_galsim.so): $PATH/lib/libc++.1.dylib found in build prefix; should never happen

I don't understand it.

beckermr commented 5 years ago

@conda-forge-admin, please rerender

beckermr commented 5 years ago

OK @brianv0. I am happy with the PR as it stands now. When you are ready, we can merge.

brianv0 commented 5 years ago

I added a run_test.py. I'm not sure what that error is, maybe it's spurious. I'm not quite sure how to debug it, unless @rmjarvis maybe has some insight.

The full error looks something like this locally:

$BUILD_PREFIX/bin/x86_64-apple-darwin13.4.0-clang++ -o galsim/_galsim.so -bundle -undefined dynamic_lookup -Wl,-pie -Wl,-headerpad_max_install_names -Wl,-dead_strip_dylibs -Wl,-rpath,$BUILD_PREFIX/lib -L$BUILD_PREFIX/lib -flto -Wl,-export_dynamic -Wl,-pie -Wl,-headerpad_max_install_names -Wl,-dead_strip_dylibs -Wl,-rpath,$BUILD_PREFIX/lib -L$BUILD_PREFIX/lib pysrc/.obj/module.os ... pysrc/.obj/WCS.os -Llib -L$PREFIX/lib -lfftw3 -lgalsim
ld: warning: -pie being ignored. It is only used when linking a main executable

...

Fixing linking of /slac/opt/conda/envs/build/conda-bld/galsim_1569171359833/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/libgalsim.2.2.dylib in /slac/opt/conda/envs/build/conda-bld/galsim_1569171359833/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.7/site-packages/galsim/_galsim.so
New link location is lib/libgalsim.2.2.dylib
Fixing linking of @rpath/libc++.1.dylib in /slac/opt/conda/envs/build/conda-bld/galsim_1569171359833/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.7/site-packages/galsim/_galsim.so
New link location is None
Fixing linking of /usr/lib/libSystem.B.dylib in /slac/opt/conda/envs/build/conda-bld/galsim_1569171359833/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.7/site-packages/galsim/_galsim.so
New link location is None

   INFO (galsim,lib/libgalsim.2.2.dylib): Needed DSO lib/libc++.1.dylib found in conda-forge::libcxx-8.0.1-0
   INFO (galsim,lib/libgalsim.2.2.dylib): Needed DSO /usr/lib/libSystem.B.dylib found in the whitelist
   INFO (galsim,lib/libgalsim.2.2.dylib): Needed DSO lib/libfftw3.3.dylib found in conda-forge::fftw-3.3.8-nompi_h9629793_1109
   INFO (galsim,lib/python3.7/site-packages/galsim/_galsim.so): Needed DSO /usr/lib/libSystem.B.dylib found in the whitelist
   INFO (galsim,lib/python3.7/site-packages/galsim/_galsim.so): lib/libgalsim.2.2.dylib found in this package
  ERROR (galsim,lib/python3.7/site-packages/galsim/_galsim.so): $PATH/lib/libc++.1.dylib found in build prefix; should never happen
WARNING (galsim): dso library package conda-forge::python-3.7.3-h93065d6_1 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)
   INFO (galsim): plugin library package conda-forge::numpy-1.11.3-py37hdf140aa_1207 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)

rmjarvis commented 5 years ago

I don't know. It's a conda-specific error message that apparently no one else has ever run across. (All the Google hits are to the source code that emits this error.) Weird.