conda-forge / gap-feedstock

A conda-smithy repository for gap.
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

Long path issue #3

Closed isuruf closed 7 years ago

isuruf commented 7 years ago

Following works

t=/tmp/asd/lb_env_plahold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol
mkdir -p $t
conda install gap=4.8.3 -c conda-forge -p $t
source activate $t
gap

Following doesn't

t=/tmp/asd/lb_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/
mkdir -p $t
conda install gap=4.8.3 -c conda-forge -p $t
source activate $t
gap

Only difference is the path.

isuruf commented 7 years ago

@williamstein, @vbraun, I'd appreciate it if you have a look.

isuruf commented 7 years ago

I forgot to mention the error, here it is.

gap: hmm, I cannot find 'lib/init.g' maybe use option '-l <gaproot>'?

This doesn't happen if the prefix is a shorter path or during conda build with a longer path.

vbraun commented 7 years ago

I think I saw that before and went with the shorter prefix. Upstream is here: https://github.com/gap-system

isuruf commented 7 years ago

Fixed in #4. I increased the size of the char buffer where the location of init.g was stored.

vbraun commented 7 years ago

Can you submit that patch to upstream?

isuruf commented 7 years ago

@vbraun, I opened an issue, https://github.com/gap-system/gap/issues/1171. I'm not entirely sure my patch wouldn't break anything else given I know nothing about gap. Had to update the patch and the new version is here, https://github.com/conda-forge/gap-feedstock/blob/v4.8.3/recipe/patches/long_path.patch