conda-forge / gap-feedstock

A conda-smithy repository for gap.
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

gap v4.12.2 #68

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
bliss 0.73-1 Anaconda-Server Badge
gap 4.12.2 Anaconda-Server Badge

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot. :/ Help is very welcome!

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/4200475742, please use this URL for debugging.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

tobiasdiez commented 1 year ago

@isuruf @saraedum Could you please try to merge this upgrade here? Sage is now using v4.12 since https://github.com/sagemath/sage/pull/35093, and due to api changes it no longer builds with v4.11. Thanks!

dimpase commented 1 year ago

It errors out on patching GAP source, specifically:

checking file bin/BuildPackages.sh
Hunk #1 FAILED at 179.
1 out of 1 hunk FAILED

This is a script used by the standard GAP way of building/installing packages. Sage is not using it, by the way.

dimpase commented 1 year ago

please merge my fix at https://github.com/regro-cf-autotick-bot/gap-feedstock/pull/1 to fix the error.

dimpase commented 1 year ago

@saraedum @isuruf

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

dimpase commented 1 year ago

oops, the other patch failed too, sorry. Fix forthcoming

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

isuruf commented 1 year ago

@conda-forge-admin, rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

dimpase commented 1 year ago

Sage is now making use of the newly available install target in GAP's makefile. Although it does not install packages. The latter got renamed, with version numbers and capitalisation removed from the names.

If you unstall libsemigroup, needed for semigroup package, you will need to bump the version to the right one.

isuruf commented 1 year ago

make install fails with

2023-03-29T00:57:19.0543610Z install: ./doc/ref/*.pdf: No such file or directory
2023-03-29T00:57:19.0642680Z install: ./doc/ref/*.lab: No such file or directory
2023-03-29T00:57:19.1030910Z install: ./doc/tut/*.pdf: No such file or directory
2023-03-29T00:57:19.1087810Z install: ./doc/tut/*.lab: No such file or directory
2023-03-29T00:57:19.1505830Z install: ./doc/hpc/*.pdf: No such file or directory
2023-03-29T00:57:19.1563810Z install: ./doc/hpc/*.lab: No such file or directory
2023-03-29T00:57:19.1568650Z make: *** [Makefile.rules:597: install-doc] Error 71
dimpase commented 1 year ago

you need to build the docs first, make doc.

fingolfin commented 1 year ago

@dimpase or instead of building the docs, just don't delete the already built docs... :-)

dimpase commented 1 year ago

Sorry, I merely shared my experience of building GAP from git source and running make install then. I haven't realised that conda uses a tarball here.

fingolfin commented 1 year ago

Well, most (all???) distros tend to build from official release tarballs, not git snapshots...

wait, does your question mean SageMath does not do this?

dimpase commented 1 year ago

SageMath uses a GAP tarball and does not delete the docs. We stoppped mangling source tarballs a while ago. And no, there was no question asked by me . :-)

saraedum commented 1 year ago

I now get:

find: ‘./float/src/.libs’: No such file or directory
find: ‘./digraphs/src/.libs’: No such file or directory
find: ‘./digraphs/.libs’: No such file or directory

What are we doing wrong @fingolfin?

fingolfin commented 1 year ago

I now see that the documentation is patched out because it is "too heavy". What does that even mean? What is the criterion here? Speaking cynically, that sound as if when I document my code too thoroughly, the result will be deleted by Conda because it is too long? I surely hope that's not the idea...

fingolfin commented 1 year ago

Anyway, other than the documentation question, I think this PR is looking really good now. Thank you very much to all who worked on this!

dimpase commented 1 year ago

SageMath does install GAP's documentation, by the way. I also don't get Conda's rationale for removing it.

On Fri, 7 Apr 2023, 11:25 Max Horn, @.***> wrote:

Anyway, other than the documentation question, I think this PR is looking really good now. Thank you very much to all who worked on this!

— Reply to this email directly, view it on GitHub https://github.com/conda-forge/gap-feedstock/pull/68#issuecomment-1500156578, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJXYHAX4M77JDV6JDBHRXTW77TP5ANCNFSM6AAAAAAU67KFR4 . You are receiving this because you were mentioned.Message ID: @.***>

saraedum commented 1 year ago

Thanks for the feedback @fingolfin. Let's get this merged as is, so we don't block the latest sagelib any further. And then we can tweak things further.

tobiasdiez commented 1 year ago

A big thanks to everyone involved, the updated version works well for me with sage!